Added software_titles unique index idx_unique_sw_titles

[ksykulev]

For #25235

This allows software with different names but the same bundle identifier
to be grouped under the same title. It also allows for software with the
same name but different bundle identifiers to be under two separate
titles.

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.
• If database migrations are included, checked table schema to confirm autoupdate
• For database migrations:
  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
• Added/updated automated tests
• A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
• Manual QA for all new/changed functionality

[iansltx]

What happens if I have "GoLand 2.app" and "GoLand.app" both with the same bundle ID? Those should resolve to the same software title. Can chat through in tmw afternoon's meeting.

Also not 100% on collations, since we have #25353. Likely worth bringing this proposal to tomorrow's backend sync to get another set of eyes on this.

[ksykulev]

I can write an explicit test for "GoLand 2.app" and "GoLand.app" both with the same bundle ID. But this doesn't seem like it worked before or after this change.

[codecov]

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.67%. Comparing base (49b0dcf) to head (42684f5).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../20250124194347_UpdateSoftwareTitlesUniqueIndex.go	56.00%	8 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #25794   +/-   ##
=======================================
  Coverage   63.67%   63.67%           
=======================================
  Files        1628     1629    +1     
  Lines      156151   156183   +32     
  Branches     4051     4051           
=======================================
+ Hits        99425    99447   +22     
- Misses      48890    48897    +7     
- Partials     7836     7839    +3     

Flag	Coverage Δ
backend	64.49% <69.44%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iansltx]

Maybe out of scope but another thing I noticed when troubleshooting for a customer related to this is a bunch of software entries with title_id values that were set but that didn't actually reference software_titles. I'm guessing the fkey was left off for performance reasons, but for sanity we should probably clean those up in ReconcileSoftwareTitles before the "clean up orphaned software titles" step, unless I'm missing something.

@mna @gillespi314 y'all touched the orphaned cleanup code most recently; is there a downside to removing invalid title_id refs where I'm mentioning?

[gillespi314]

I'm guessing the fkey was left off for performance reasons,

Yes, I think that was the reason.

but for sanity we should probably clean those up in ReconcileSoftwareTitles before the "clean up orphaned software titles" step, unless I'm missing something.

By cleanup do you mean update the software table to set software.title_id = NULL where the id doesn't exist in the software_titles table?

[iansltx]

@gillespi314 yep, that's that I mean. Sounds like we're good to do that.

[iansltx]

Code LGTM. Good to merge once CI passes.