Skip to content

Add Secureframe partnership override env var for transparency URL#27388

Merged
iansltx merged 3 commits intomainfrom
27309-secureframe-url
Mar 31, 2025
Merged

Add Secureframe partnership override env var for transparency URL#27388
iansltx merged 3 commits intomainfrom
27309-secureframe-url

Conversation

@iansltx
Copy link
Member

@iansltx iansltx commented Mar 21, 2025

For #27309.

  • Manual QA for all new/changed functionality
  • Added automated tests

@iansltx iansltx requested a review from a team as a code owner March 21, 2025 14:34
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.77%. Comparing base (f351cb2) to head (e7fe01b).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
server/service/devices.go 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #27388      +/-   ##
==========================================
+ Coverage   60.05%   63.77%   +3.72%     
==========================================
  Files        1745     1745              
  Lines      165806   165827      +21     
  Branches     4535     4535              
==========================================
+ Hits        99568   105762    +6194     
+ Misses      58534    51813    -6721     
- Partials     7704     8252     +548     
Flag Coverage Δ
backend 64.58% <88.23%> (+4.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukeheath
Copy link
Member

Since this story is still in drafting, it's up to @noahtalerman when we want to merge this.

@iansltx iansltx force-pushed the 27309-secureframe-url branch from ee199d1 to e7fe01b Compare March 26, 2025 23:24
@iansltx iansltx assigned ksykulev and unassigned lukeheath and noahtalerman Mar 26, 2025
@lukeheath lukeheath marked this pull request as draft March 31, 2025 18:45
@lukeheath
Copy link
Member

@iansltx Converting this to draft since we're not 100% sure what the code needs to look like yet (still in drafting AFAIK).

@iansltx
Copy link
Member Author

iansltx commented Mar 31, 2025

@lukeheath This passed through user story review last Tuesday, and spec'ing happened at/before USR so this got moved to estimated shortly thereafter. So this has been out of drafting for a bit already.

@lukeheath lukeheath marked this pull request as ready for review March 31, 2025 18:55
@lukeheath
Copy link
Member

Okay I was just out of the loop and this is ready to merge.

Copy link
Contributor

@ksykulev ksykulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. Looks good to me 👍

@iansltx iansltx merged commit 5ee8af6 into main Mar 31, 2025
35 checks passed
@iansltx iansltx deleted the 27309-secureframe-url branch March 31, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants