Cherry-Pick: Remove default EXE install/uninstall scripts, require entering install/uninstall scripts on EXE upload#27709
Merged
iansltx merged 2 commits intorc-minor-fleet-v4.66.0from Apr 1, 2025
Conversation
…l/uninstall scripts on EXE upload (#27268) For #27267. Below is what's shown immediately after selecting an EXE: <img width="1254" alt="image" src="https://github.com/user-attachments/assets/a28d8565-de88-448a-bdbc-92aefc34ad55" /> TODO: * Tests * GitOps requirements changes * Disabling add button/adding errors when required scripts aren't specified # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated automated tests - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Luke Heath <luke@fleetdm.com> Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com> Co-authored-by: RachelElysia <rachel@fleetdm.com>
iansltx
requested review from
a team,
georgekarrv,
lukeheath,
mostlikelee and
sharon-fdm
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.66.0 #27709 +/- ##
=========================================================
Coverage ? 63.78%
=========================================================
Files ? 1744
Lines ? 165794
Branches ? 4488
=========================================================
Hits ? 105746
Misses ? 51802
Partials ? 8246
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukeheath
approved these changes
Mar 31, 2025
Member
Author
|
@lukeheath sorry, I'm gonna pull the workflow change out of this because, since the it-and-security script move didn't get cherry-picked, this breaks that test rather than fixing it. On a call now otherwise I would've fixed that earlier. |
jahzielv
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged into
mainin #27268.