Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28832 +/- ##
==========================================
+ Coverage 64.16% 64.20% +0.04%
==========================================
Files 1815 1816 +1
Lines 174346 175865 +1519
Branches 5118 5118
==========================================
+ Hits 111867 112915 +1048
- Misses 53696 54082 +386
- Partials 8783 8868 +85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ra-id # Conflicts: # server/datastore/mysql/scim_test.go
8 tasks
lukeheath
approved these changes
May 8, 2025
lukeheath
approved these changes
May 8, 2025
Member
lukeheath
left a comment
lukeheath
left a comment
There was a problem hiding this comment.
Approving contributor doc changes, not code changes.
gillespi314
approved these changes
May 8, 2025
Contributor
gillespi314
left a comment
gillespi314
left a comment
There was a problem hiding this comment.
LGTM, thanks for all the tests :)
getvictor
added a commit
that referenced
this pull request
May 8, 2025
For #28196 This PR depends on PR #28832 This PR adds support for excludeAttributes=members, which is being used by Microsoft Entra ID. This PR modifies the primary key of host_scim_user table to be host_id. This should have been done initially and has added accidental complexity and maintainability challenges, so we are doing it now. This means a host can have a maximum of 1 SCIM user associated with it. A SCIM user, on the other hand, can be associated with multiple hosts. # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - [x] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [x] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [x] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [x] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [x] Added/updated automated tests - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #28196
This PR adds full patching for SCIM Users and Groups, and adds the ability to filter Groups by displayName.
The changes have been tested with Entra ID SCIM Validator and Okta SCIM 2.0 SPEC Test (to make sure we didn't break Okta).
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.