Follow-up API design for #28389#29200
Merged
rachaelshaw merged 6 commits intodocs-v4.69.0from May 27, 2025
Merged
Conversation
fleet-release
approved these changes
May 15, 2025
fleet-release
approved these changes
May 15, 2025
4 tasks
Contributor
|
@sgress454 heads up - for the UI to successfully push to the scripts page, it will need to get the |
sgress454
reviewed
May 20, 2025
4 tasks
sgress454
added a commit
that referenced
this pull request
May 22, 2025
# Checklist for submitter - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] Added/updated automated tests - [X] Manual QA for all new/changed functionality ## Details This PR adds a new `GET /scripts/batch/summary/:batch_execution_id` endpoint that returns a summary of the current state of a batch script execution, including some basic info about the script being executed and a breakdown of how hosts have responded. See #29200 for API response.
Co-authored-by: jacobshandling <61553566+jacobshandling@users.noreply.github.com>
fleet-release
approved these changes
May 27, 2025
Co-authored-by: jacobshandling <61553566+jacobshandling@users.noreply.github.com>
fleet-release
approved these changes
May 27, 2025
Co-authored-by: jacobshandling <61553566+jacobshandling@users.noreply.github.com>
fleet-release
approved these changes
May 27, 2025
rachaelshaw
commented
May 27, 2025
fleet-release
approved these changes
May 27, 2025
Co-authored-by: Scott Gress <scottmgress@gmail.com>
fleet-release
approved these changes
May 27, 2025
rachaelshaw
commented
May 27, 2025
| "targeted": 12599, | ||
| "script_id": 555, | ||
| "script_name": "my-script.sh", | ||
| "team_id": 123 |
Member
Author
There was a problem hiding this comment.
@sgress454 @jacobshandling just realized we'll also want created_at (for the tooltip in the filter UI that's coming up next) — we can add that in the next iteration if we're currently grabbing that from the activity
Contributor
There was a problem hiding this comment.
we're currently grabbing that from the activity
Yep this is what the UI is currently doing, good catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the summary endpoint for a batch-run script.