[Activity changes] Enroll personally owned (BYOD) iOS/iPadOS devices with work email (Managed Apple Account)#30186
[Activity changes] Enroll personally owned (BYOD) iOS/iPadOS devices with work email (Managed Apple Account)#30186marko-lisica wants to merge 5 commits intomainfrom
Conversation
Co-authored-by: Gabriel Hernandez <ghernandez345@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey @ghernandez345 @marko-lisica we shipped the user story but it looks like these activity changes aren't in the audit logs doc page: https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/audit-logs.md Did we forget to generate the new audit logs? https://fleetdm.com/handbook/company/communications#audit-logs |
|
@marko-lisica just coming back from time off and checking if we need to still do this? if so let me know and I can get this across the line |
|
Hey @ghernandez345, welcome back! Yes, we want this. |
FYI @marko-lisica @ghernandez345 More info in the Slack thread: https://fleetdm.slack.com/archives/C03C41L5YEL/p1756480485506969 |
UPDATE: @noahtalerman: We decided to add
enrollment_id. We decided not to addpersonal_host(PR here).enrollment_idwhich isnullexcept for personal enrollments where it has a value.Closing this PR. Won't merge PRs to the
audit-logs.mdfile. This file is edited during development.Related to: