Skip to content

Tweak CVE feed build to avoid false positives in CVE-2024-54559 #30293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iansltx merged 1 commit into from
Jun 25, 2025
Merged

Tweak CVE feed build to avoid false positives in CVE-2024-54559 #30293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions server/vulnerabilities/nvd/cve_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,14 @@ func TestTranslateCPEToCVE(t *testing.T) {
},
continuesToUpdate: true,
},
"cpe:2.3:a:apple:garageband:10.4.11:*:*:*:*:macos:*:*": {
excludedCVEs: []string{"CVE-2024-54559"},
continuesToUpdate: true,
},
"cpe:2.3:o:apple:macos:15.1.1:*:*:*:*:*:*:*": {
includedCVEs: []cve{{ID: "CVE-2024-54559", resolvedInVersion: "15.2"}},
continuesToUpdate: true,
},
"cpe:2.3:a:avira:password_manager:2.18.4.38471:*:*:*:*:firefox:*:*": {
includedCVEs: []cve{
{ID: "CVE-2022-28795"},
Expand Down
12 changes: 11 additions & 1 deletion server/vulnerabilities/nvd/sync/cve_syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ func (s *CVE) sync(ctx context.Context, lastModStartDate *string) (newLastModSta
return "", err
}
vulnerabilitiesReceived++
cvesByYear[year] = append(cvesByYear[year], vuln)
cvesByYear[year] = append(cvesByYear[year], transformVuln(vuln))
}

// Dump vulnerabilities to the year files to reduce memory footprint.
Expand Down Expand Up @@ -481,6 +481,16 @@ func (s *CVE) sync(ctx context.Context, lastModStartDate *string) (newLastModSta
return newLastModStartDate, nil
}

// cleans up vulnerability feed entries that are incorrect from NVD, allowing fixing bugged NVD rules without needing
// to update Fleet server
func transformVuln(item nvdapi.CVEItem) nvdapi.CVEItem {
if item.CVE.ID != nil && *item.CVE.ID == "CVE-2024-54559" {
item.CVE.Configurations[0].Nodes[0].CPEMatch = item.CVE.Configurations[0].Nodes[0].CPEMatch[0:1]
}

return item
}

func (s *CVE) DoVulnCheck(ctx context.Context) error {
vulnCheckArchive := "vulncheck.zip"
baseURL := "https://api.vulncheck.com/v3/backup/nist-nvd2"
Expand Down
Loading