Use ASN.1 format to store TPM child key by lucasmrod · Pull Request #31131 · fleetdm/fleet

lucasmrod · 2025-07-22T14:23:23Z

We were storing public key bytes and encrypted private key bytes as raw files called tpm_cms_pub.blob and tpm_cms_priv.blob respectively. This PR changes to use a better format on a single file that looks like this:

"-----BEGIN TSS2 PRIVATE KEY-----"
[...]
"-----END TSS2 PRIVATE KEY-----"

(We haven't released this feature yet so we don't need a migration.)

coderabbitai · 2025-07-22T14:23:29Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch use-tss2-format-to-store-child-key

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-07-22T14:36:00Z

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 64.04%. Comparing base (d256bfd) to head (142c9e3).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
ee/orbit/pkg/securehw/securehw_linux.go	0.00%	25 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #31131      +/-   ##
==========================================
+ Coverage   64.01%   64.04%   +0.02%     
==========================================
  Files        1905     1905              
  Lines      187633   187578      -55     
  Branches     5415     5415              
==========================================
+ Hits       120122   120130       +8     
+ Misses      58068    58006      -62     
+ Partials     9443     9442       -1

Flag	Coverage Δ
backend	`64.90% <0.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lucasmrod · 2025-07-22T17:10:41Z

 // tpm2Signer implements crypto.Signer using TPM 2.0.
 type tpm2Signer struct {
-	tpm       transport.TPMCloser
+	tpm       transport.TPM


There was no need for this type to be a Closer.

sgress454

I'm not able to run this (or the tests) because I don't have a compatible system, but it looks good to me based on the docs for github.com/foxboron/go-tpm-keyfiles.

Foxboron · 2025-07-25T12:46:32Z

-		return fmt.Errorf("write public blob to %s: %w", t.publicBlobPath, err)
+func (t *tpm2TEE) saveTPMKeyFile(privateKey tpm2.TPM2BPrivate, publicKey tpm2.TPM2BPublic) error {
+	k := keyfile.NewTPMKey(
+		keyfile.OIDOldLoadableKey,


You probably want keyfile.OIDLoadableKey here. I realize now that the README.md example is using the wrong OID.

Oh thank you! I totally missed the "Old" part there.

And double thanks for catching this before our agent release :)

@Foxboron

See #31131 (review). Thanks @Foxboron!

@Foxboron

See #31131 (review). Thanks @Foxboron!

Use ASN.1 format to store TPM child key

a007c32

lucasmrod assigned sgress454 Jul 22, 2025

lucasmrod requested a review from a team as a code owner July 22, 2025 14:23

lucasmrod temporarily deployed to Docker Hub July 22, 2025 14:23 — with GitHub Actions Inactive

Fix lint

142c9e3

lucasmrod temporarily deployed to Docker Hub July 22, 2025 14:36 — with GitHub Actions Inactive

lucasmrod commented Jul 22, 2025

View reviewed changes

sgress454 approved these changes Jul 22, 2025

View reviewed changes

lucasmrod merged commit 26a0425 into main Jul 23, 2025
39 checks passed

lucasmrod deleted the use-tss2-format-to-store-child-key branch July 23, 2025 00:15

Foxboron reviewed Jul 25, 2025

View reviewed changes

lucasmrod mentioned this pull request Jul 25, 2025

Fix wrong OID in keyfile #31262

Merged

lucasmrod added a commit that referenced this pull request Jul 25, 2025

Fix wrong OID in keyfile (#31262)

17071cb

See #31131 (review). Thanks @Foxboron!

lucasmrod added a commit that referenced this pull request Jul 25, 2025

Fix wrong OID in keyfile (#31262)

6cc2a2c

See #31131 (review). Thanks @Foxboron!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ASN.1 format to store TPM child key#31131

Use ASN.1 format to store TPM child key#31131
lucasmrod merged 2 commits intomainfrom
use-tss2-format-to-store-child-key

lucasmrod commented Jul 22, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov Bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

lucasmrod Jul 22, 2025 •

edited

Loading

Uh oh!

sgress454 left a comment

Uh oh!

Uh oh!

Foxboron Jul 25, 2025

Uh oh!

lucasmrod Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lucasmrod commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov Bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lucasmrod Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sgress454 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Foxboron Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

lucasmrod Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lucasmrod commented Jul 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov Bot commented Jul 22, 2025 •

edited

Loading

lucasmrod Jul 22, 2025 •

edited

Loading