Skip to content

Moving categories, setup_experience and self_service up to team yml#31811

Merged
ksykulev merged 6 commits into30095-gitops-changesfrom
31164-generate-gitops
Aug 18, 2025
Merged

Moving categories, setup_experience and self_service up to team yml#31811
ksykulev merged 6 commits into30095-gitops-changesfrom
31164-generate-gitops

Conversation

@ksykulev
Copy link
Copy Markdown
Contributor

@ksykulev ksykulev commented Aug 12, 2025

Fixes #31164

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests

  • QA'd all new/changed functionality manually

  • Verified that the setting is exported via fleetctl generate-gitops

  • Verified the setting is documented in a separate PR to the GitOps documentation

  • Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.77%. Comparing base (8ad5a43) to head (bde5c32).
⚠️ Report is 45 commits behind head on 30095-gitops-changes.

Files with missing lines Patch % Lines
cmd/fleetctl/fleetctl/generate_gitops.go 71.42% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           30095-gitops-changes   #31811      +/-   ##
========================================================
+ Coverage                 63.57%   63.77%   +0.20%     
========================================================
  Files                      1964     1966       +2     
  Lines                    192340   192576     +236     
  Branches                   6276     6276              
========================================================
+ Hits                     122285   122822     +537     
+ Misses                    60460    60141     -319     
- Partials                   9595     9613      +18     
Flag Coverage Δ
backend 65.16% <71.42%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ksykulev ksykulev marked this pull request as ready for review August 12, 2025 19:51
@ksykulev ksykulev requested a review from a team as a code owner August 12, 2025 19:51
Comment thread cmd/fleetctl/fleetctl/testdata/generateGitops/expectedTeamSoftware.yaml Outdated
@iansltx iansltx changed the base branch from main to 30095-gitops-changes August 13, 2025 16:51
@ksykulev ksykulev changed the title Moving categories, install_during_setup and self_service up to team yml Moving categories, setup_experience and self_service up to team yml Aug 13, 2025
@jahzielv jahzielv requested a review from iansltx August 13, 2025 21:01
Copy link
Copy Markdown
Contributor

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does mean the macOS setup experience bail-out is being tested less, but this shouldn't be an issue, so fair enough.

@ksykulev ksykulev merged commit 2c55abb into 30095-gitops-changes Aug 18, 2025
42 checks passed
@ksykulev ksykulev deleted the 31164-generate-gitops branch August 18, 2025 15:30
iansltx pushed a commit that referenced this pull request Aug 20, 2025
…31811)

Fixes #31164

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

- [X] Verified that the setting is exported via `fleetctl
generate-gitops`
- [X] Verified the setting is documented in a separate PR to [the GitOps
documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485)
- [X] Verified that the setting is cleared on the server if it is not
supplied in a YAML file (or that it is documented as being optional)
iansltx pushed a commit that referenced this pull request Sep 2, 2025
…31811)

Fixes #31164

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

- [X] Verified that the setting is exported via `fleetctl
generate-gitops`
- [X] Verified the setting is documented in a separate PR to [the GitOps
documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485)
- [X] Verified that the setting is cleared on the server if it is not
supplied in a YAML file (or that it is documented as being optional)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitOps software/setup experience restructure: fleetctl generate-gitops changes

3 participants