Skip to content

Conversation

@juan-fdz-hawa
Copy link
Contributor

For #30384

Minor refactorings suggested in #31634.

No new changes introduced, so change file not required.

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.77%. Comparing base (4ff53b9) to head (d318b7d).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/disk_encryption.go 0.00% 6 Missing ⚠️
server/service/orbit.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #31839      +/-   ##
==========================================
+ Coverage   63.58%   63.77%   +0.19%     
==========================================
  Files        1964     1966       +2     
  Lines      192352   192508     +156     
  Branches     6285     6285              
==========================================
+ Hits       122300   122772     +472     
+ Misses      60456    60129     -327     
- Partials     9596     9607      +11     
Flag Coverage Δ
backend 65.15% <0.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan-fdz-hawa juan-fdz-hawa merged commit 684b055 into main Aug 13, 2025
43 checks passed
@juan-fdz-hawa juan-fdz-hawa deleted the 30384-escrowed_disk_encryption_key-activity-refactorings branch August 13, 2025 14:24
BCTBB pushed a commit that referenced this pull request Aug 19, 2025
For #30384

Minor refactorings suggested in
#31634.

No new changes introduced, so change file not required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants