Skip to content

Conversation

@MagnusHJensen
Copy link
Member

@MagnusHJensen MagnusHJensen commented Aug 15, 2025

fixes: #31168

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Testing

  • Added/updated automated tests

  • QA'd all new/changed functionality manually

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 74.46809% with 24 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat-hydrant-ca@a040d77). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/fleet/certificate_authorities.go 77.27% 9 Missing and 1 partial ⚠️
server/service/apple_mdm.go 79.31% 4 Missing and 2 partials ⚠️
server/datastore/mysql/certificate_authorities.go 50.00% 2 Missing and 1 partial ⚠️
server/service/mdm.go 50.00% 2 Missing and 1 partial ⚠️
ee/server/service/scep_proxy.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             feat-hydrant-ca   #31959   +/-   ##
==================================================
  Coverage                   ?   63.83%           
==================================================
  Files                      ?     1971           
  Lines                      ?   193297           
  Branches                   ?     6358           
==================================================
  Hits                       ?   123389           
  Misses                     ?    60241           
  Partials                   ?     9667           
Flag Coverage Δ
backend 65.18% <74.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat-api-get-cert-authorities-endpoint to feat-hydrant-ca August 15, 2025 13:35
@MagnusHJensen MagnusHJensen marked this pull request as ready for review August 18, 2025 12:05
@MagnusHJensen MagnusHJensen requested a review from a team as a code owner August 18, 2025 12:05
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MagnusHJensen MagnusHJensen merged commit 84cb7bf into feat-hydrant-ca Aug 18, 2025
42 checks passed
@MagnusHJensen MagnusHJensen deleted the 31168-move-ca-variables-to-db-table branch August 18, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HCA: Support existing CA variables in profiles

2 participants