Skip to content

Stop showing debug logs during fleetctl preview, slight reformat#33352

Merged
dantecatalfamo merged 2 commits intomainfrom
32208-fleetctl-preview-logging
Sep 23, 2025
Merged

Stop showing debug logs during fleetctl preview, slight reformat#33352
dantecatalfamo merged 2 commits intomainfrom
32208-fleetctl-preview-logging

Conversation

@dantecatalfamo
Copy link
Copy Markdown
Member

@dantecatalfamo dantecatalfamo commented Sep 23, 2025

Related issue: #32208

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • QA'd all new/changed functionality manually

Also added a spinner while waiting for docker compose to start and stop, added some spacing around the login information, and bolded the username and password.

image

@dantecatalfamo dantecatalfamo marked this pull request as ready for review September 23, 2025 15:39
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner September 23, 2025 15:39
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.08%. Comparing base (11fa6ff) to head (0e1688d).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cmd/fleetctl/fleetctl/preview.go 78.12% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33352      +/-   ##
==========================================
- Coverage   64.08%   64.08%   -0.01%     
==========================================
  Files        2061     2061              
  Lines      205110   205176      +66     
  Branches     6677     6677              
==========================================
+ Hits       131438   131479      +41     
- Misses      63306    63326      +20     
- Partials    10366    10371       +5     
Flag Coverage Δ
backend 65.20% <78.12%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@sgress454 sgress454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy

@dantecatalfamo dantecatalfamo linked an issue Sep 23, 2025 that may be closed by this pull request
@dantecatalfamo dantecatalfamo merged commit eb16ef4 into main Sep 23, 2025
44 checks passed
@dantecatalfamo dantecatalfamo deleted the 32208-fleetctl-preview-logging branch September 23, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fleetctl preview: Logs in the ouput

2 participants