Skip to content

Unbatch software checksum migration#34485

Merged
georgekarrv merged 1 commit into
rc-patch-fleet-v4.75.1from
unbatch-checksums
Oct 21, 2025
Merged

Unbatch software checksum migration#34485
georgekarrv merged 1 commit into
rc-patch-fleet-v4.75.1from
unbatch-checksums

Conversation

@ksykulev
Copy link
Copy Markdown
Contributor

@ksykulev ksykulev commented Oct 18, 2025

#34559

Issue #28788
related to PR #34289

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-patch-fleet-v4.75.1@f6631e2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...51015103505_AddNameToSoftwareCheckumCalculation.go 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-patch-fleet-v4.75.1   #34485   +/-   ##
=========================================================
  Coverage                          ?   65.14%           
=========================================================
  Files                             ?     1350           
  Lines                             ?   186229           
  Branches                          ?        0           
=========================================================
  Hits                              ?   121311           
  Misses                            ?    54535           
  Partials                          ?    10383           
Flag Coverage Δ
backend 65.14% <91.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sharon-fdm sharon-fdm linked an issue Oct 20, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@sgress454 sgress454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test result of the migration, which I assume was tested in the original PR, but the updated code looks good and the migration ran without error.

@ksykulev ksykulev marked this pull request as ready for review October 20, 2025 21:02
@ksykulev ksykulev requested a review from a team as a code owner October 20, 2025 21:02
@georgekarrv georgekarrv changed the base branch from rc-minor-fleet-v4.75.0 to rc-patch-fleet-v4.75.1 October 21, 2025 01:30
@georgekarrv georgekarrv merged commit 2c59b95 into rc-patch-fleet-v4.75.1 Oct 21, 2025
36 checks passed
@georgekarrv georgekarrv deleted the unbatch-checksums branch October 21, 2025 01:30
ksykulev added a commit that referenced this pull request Oct 21, 2025
**Related issue:** #34559
PR for 4.75.1: #34485

needs to be added in main to be consistent.
ksykulev added a commit that referenced this pull request Oct 21, 2025
**Related issue:** #34559
PR for 4.75.1: #34485

needs to be added in main to be consistent.
ksykulev added a commit that referenced this pull request Oct 21, 2025
mna pushed a commit that referenced this pull request Oct 27, 2025
**Related issue:** #34559
PR for 4.75.1: #34485

needs to be added in main to be consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unbatch software checksum migration

3 participants