Skip to content

Unbatching checksum migration #34586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksykulev merged 1 commit into from
Oct 21, 2025
Merged

Unbatching checksum migration #34586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions ...r/datastore/mysql/migrations/tables/20251015103505_AddNameToSoftwareCheckumCalculation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,7 @@ func init() {
}

func Up_20251015103505(tx *sql.Tx) error {
var minID, maxID sql.NullInt64
err := tx.QueryRow(`
SELECT MIN(id), MAX(id)
FROM software
WHERE source = 'apps'
AND bundle_identifier IS NOT NULL
AND bundle_identifier != ''
`).Scan(&minID, &maxID)
if err != nil {
return fmt.Errorf("getting ID range: %w", err)
}

if !minID.Valid || !maxID.Valid {
return nil
}

const batchSize = 10000
for startID := minID.Int64; startID <= maxID.Int64; startID += batchSize {
endID := startID + batchSize - 1
if endID > maxID.Int64 {
endID = maxID.Int64
}

softwareStmt := `
softwareStmt := `
UPDATE software SET
checksum = UNHEX(
MD5(
Expand All @@ -54,12 +31,10 @@ func Up_20251015103505(tx *sql.Tx) error {
WHERE source = 'apps'
AND bundle_identifier IS NOT NULL
AND bundle_identifier != ''
AND id >= ? AND id <= ?
`
_, err = tx.Exec(softwareStmt, startID, endID)
if err != nil {
return fmt.Errorf("updating software checksums (batch %d-%d): %w", startID, endID, err)
}
_, err := tx.Exec(softwareStmt)
if err != nil {
return fmt.Errorf("updating software checksums %w", err)
}

return nil
Expand Down
Loading