Skip to content

Add Fleet Desktop.app to .gitignore#37711

Merged
lucasmrod merged 2 commits intomainfrom
35006-add-tmp-folder-to-.gitignore
Jan 5, 2026
Merged

Add Fleet Desktop.app to .gitignore#37711
lucasmrod merged 2 commits intomainfrom
35006-add-tmp-folder-to-.gitignore

Conversation

@lucasmrod
Copy link
Copy Markdown
Member

@lucasmrod lucasmrod commented Dec 26, 2025

Resolves #35006.
See #35006 (comment).

Output when running the dirty check on main:

make desktop-app-tar-gz
go run ./tools/desktop macos
{"level":"info","command":"/Users/lucas/go/bin/go build -o Fleet Desktop.app/Contents/MacOS/fleet-desktop_amd64 -ldflags -X=main.version= ./orbit/cmd/desktop","time":"2025-12-30T08:38:20-03:00","message":"Build fleet-desktop executable amd64"}
{"level":"info","command":"/Users/lucas/go/bin/go build -o Fleet Desktop.app/Contents/MacOS/fleet-desktop_arm64 -ldflags -X=main.version= ./orbit/cmd/desktop","time":"2025-12-30T08:38:23-03:00","message":"Build fleet-desktop executable arm64"}
{"level":"info","output":"On branch test-branch-dirty\nUntracked files:\n  (use \"git add <file>...\" to include in what will be committed)\n\tFleet Desktop.app/\n\nnothing added to commit but untracked files present (use \"git add\" to track)\n","time":"2025-12-30T08:38:26-03:00","message":"git status"}
Error: detected dirty executable: {Path:github.com/fleetdm/fleet/v4 Version:v4.43.5-0.20251230113816-9bae7b475999+dirty Sum: Replace:<nil>}
exit status 1
make: *** [desktop-app-tar-gz] Error 1

Output on this branch:

make desktop-app-tar-gz
go run ./tools/desktop macos
{"level":"info","command":"/Users/lucas/go/bin/go build -o Fleet Desktop.app/Contents/MacOS/fleet-desktop_amd64 -ldflags -X=main.version= ./orbit/cmd/desktop","time":"2025-12-30T08:39:43-03:00","message":"Build fleet-desktop executable amd64"}
{"level":"info","command":"/Users/lucas/go/bin/go build -o Fleet Desktop.app/Contents/MacOS/fleet-desktop_arm64 -ldflags -X=main.version= ./orbit/cmd/desktop","time":"2025-12-30T08:39:47-03:00","message":"Build fleet-desktop executable arm64"}
Generated desktop.app.tar.gz successfully.
  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

fleetd/orbit/Fleet Desktop

  • Verified that fleetd runs on macOS
  • Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

iansltx
iansltx previously approved these changes Dec 26, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.82%. Comparing base (cc1485c) to head (2832135).
⚠️ Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37711      +/-   ##
==========================================
- Coverage   65.88%   65.82%   -0.06%     
==========================================
  Files        2361     2362       +1     
  Lines      187298   187509     +211     
  Branches     7908     7908              
==========================================
+ Hits       123394   123437      +43     
- Misses      52622    52774     +152     
- Partials    11282    11298      +16     
Flag Coverage Δ
backend 67.67% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucasmrod lucasmrod assigned iansltx and unassigned JordanMontgomery Jan 5, 2026
@lucasmrod lucasmrod merged commit 505beae into main Jan 5, 2026
45 checks passed
@lucasmrod lucasmrod deleted the 35006-add-tmp-folder-to-.gitignore branch January 5, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fleet desktop macOS builds show up as "dirty"(i.e. source code modified) when inspected

3 participants