Fix flaky test: Use setSkipWorkerJobs#39106
Merged
gillespi314 merged 1 commit intomainfrom Feb 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39106 +/- ##
=======================================
Coverage 66.18% 66.18%
=======================================
Files 2423 2423
Lines 194078 194078
Branches 8518 8518
=======================================
+ Hits 128452 128453 +1
Misses 53947 53947
+ Partials 11679 11678 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mna
approved these changes
Feb 2, 2026
sgress454
added a commit
that referenced
this pull request
Feb 25, 2026
…40536) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #40535 Fixes a flaky test (and possibly others) by turning off worker jobs while the test is running. @gillespi314 did a similar fix recently in #39106; this adds it to other vulnerable tests including `TestSetupExperienceFlowWithRequiredSoftwareVPP` which I recently got a failure on in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #38898
Looking at the logs from the issue, we see that the command to install fleetd is being sent twice, which indicates the worker job ran twice. Speculative fix to setSkipWorkerJobs was validated with RandoKiller™.