Bugfix: use custom software title icon and display name in setup experience UI#39223
Merged
Bugfix: use custom software title icon and display name in setup experience UI#39223
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39223 +/- ##
==========================================
- Coverage 66.18% 64.32% -1.86%
==========================================
Files 2424 2392 -32
Lines 194205 187003 -7202
Branches 8523 8457 -66
==========================================
- Hits 128543 120298 -8245
- Misses 53975 55799 +1824
+ Partials 11687 10906 -781
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jahzielv
reviewed
Feb 3, 2026
|
|
||
| // DisplayName and IconURL are populated by ListSetupExperienceResultsByHostUUID and | ||
| // are only used for display purposes in the UI. | ||
| DisplayName string `json:"display_name,omitempty" db:"-"` |
Contributor
There was a problem hiding this comment.
Will these changes require API documentation?
Member
Author
There was a problem hiding this comment.
Ah good call, I thought no because it is in contributor's API, but looks like we still have an example response payload, so I'll push a PR for that.
jahzielv
approved these changes
Feb 3, 2026
Member
Author
|
CI failures are unrelated (Scott is working on a fix). |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #38343
Checklist for submitter
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)Testing
Repro of the issue (Munki should have a custom icon and be called "Custom Munki"): https://drive.google.com/file/d/1tLWHYNaFC_A0p-2fmsPKgmIlW4cBDJzd/view?usp=drive_link
Screenshot of the setup experience UI with the fix:

Setup experience flow with fix recording: https://drive.google.com/file/d/1LUkijFxOc2mo9MCOBZop7PzpkxovzuBh/view?usp=drive_link