Skip to content

Bugfix: use custom software title icon and display name in setup experience UI#39223

Merged
mna merged 9 commits intomainfrom
mna-38343-custom-title-icon-in-setup-exp
Feb 3, 2026
Merged

Bugfix: use custom software title icon and display name in setup experience UI#39223
mna merged 9 commits intomainfrom
mna-38343-custom-title-icon-in-setup-exp

Conversation

@mna
Copy link
Copy Markdown
Member

@mna mna commented Feb 3, 2026

Related issue: Resolves #38343

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

Repro of the issue (Munki should have a custom icon and be called "Custom Munki"): https://drive.google.com/file/d/1tLWHYNaFC_A0p-2fmsPKgmIlW4cBDJzd/view?usp=drive_link

Screenshot of the setup experience UI with the fix:
image

Setup experience flow with fix recording: https://drive.google.com/file/d/1LUkijFxOc2mo9MCOBZop7PzpkxovzuBh/view?usp=drive_link

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.32%. Comparing base (d5ba60d) to head (fb854eb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/setup_experience.go 80.00% 3 Missing and 2 partials ⚠️
server/service/devices.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #39223      +/-   ##
==========================================
- Coverage   66.18%   64.32%   -1.86%     
==========================================
  Files        2424     2392      -32     
  Lines      194205   187003    -7202     
  Branches     8523     8457      -66     
==========================================
- Hits       128543   120298    -8245     
- Misses      53975    55799    +1824     
+ Partials    11687    10906     -781     
Flag Coverage Δ
backend 65.86% <84.21%> (-2.09%) ⬇️
frontend 54.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mna mna marked this pull request as ready for review February 3, 2026 19:12
@mna mna requested review from a team as code owners February 3, 2026 19:12

// DisplayName and IconURL are populated by ListSetupExperienceResultsByHostUUID and
// are only used for display purposes in the UI.
DisplayName string `json:"display_name,omitempty" db:"-"`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these changes require API documentation?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good call, I thought no because it is in contributor's API, but looks like we still have an example response payload, so I'll push a PR for that.

@mna
Copy link
Copy Markdown
Member Author

mna commented Feb 3, 2026

CI failures are unrelated (Scott is working on a fix).

@mna mna merged commit 838de3f into main Feb 3, 2026
44 of 50 checks passed
@mna mna deleted the mna-38343-custom-title-icon-in-setup-exp branch February 3, 2026 19:56
rachaelshaw pushed a commit that referenced this pull request Feb 3, 2026
…con for setup experience software (#39262)

Docs changes for #39223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom software titles/icons not respected in macOS setup experience

2 participants