Skip to content

Fix orbit panic when auto-updates disabled#40202

Merged
getvictor merged 1 commit intomainfrom
victor/40200-auto-update-panic
Feb 20, 2026
Merged

Fix orbit panic when auto-updates disabled#40202
getvictor merged 1 commit intomainfrom
victor/40200-auto-update-panic

Conversation

@getvictor
Copy link
Member

@getvictor getvictor commented Feb 20, 2026

Related issue: Resolves #40200

QA done as part of #40142 PR

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.

Testing

  • QA'd all new/changed functionality manually

fleetd/orbit/Fleet Desktop

  • Verified compatibility with the latest released version of Fleet (see Must rule)
  • If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • Verified that fleetd runs on macOS, Linux and Windows
  • Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

@getvictor getvictor marked this pull request as ready for review February 20, 2026 19:02
@getvictor getvictor requested a review from a team as a code owner February 20, 2026 19:02
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the panic but I think it will also make it so that the gzip setting is never turned on if updates are disabled. Works for a short-term patch but I think we should find a way to enable it longer term.

Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasmrod lucasmrod self-assigned this Feb 20, 2026
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct to me.

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@getvictor getvictor merged commit 06c192f into main Feb 20, 2026
48 checks passed
@getvictor getvictor deleted the victor/40200-auto-update-panic branch February 20, 2026 19:26
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.34%. Comparing base (318c257) to head (7ec5e93).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
orbit/cmd/orbit/orbit.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40202      +/-   ##
==========================================
- Coverage   66.34%   66.34%   -0.01%     
==========================================
  Files        2453     2453              
  Lines      196518   196523       +5     
  Branches     8539     8681     +142     
==========================================
+ Hits       130388   130390       +2     
- Misses      54320    54323       +3     
  Partials    11810    11810              
Flag Coverage Δ
backend 68.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lucasmrod pushed a commit that referenced this pull request Feb 20, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #40200

QA done as part of #40142 PR

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.

## Testing

- [x] QA'd all new/changed functionality manually

## fleetd/orbit/Fleet Desktop

- [x] Verified compatibility with the latest released version of Fleet
(see [Must
rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/workflows/fleetd-development-and-release-strategy.md))
- [x] If the change applies to only one platform, confirmed that
`runtime.GOOS` is used as needed to isolate changes
- [x] Verified that fleetd runs on macOS, Linux and Windows
- [x] Verified auto-update works from the released version of component
to the new version (see [tools/tuf/test](../tools/tuf/test/README.md))
lucasmrod added a commit that referenced this pull request Feb 20, 2026
Cherry-pick to the new branch for fleetd 1.52.1.

Co-authored-by: Victor Lyuboslavsky <2685025+getvictor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

orbit v1.52.0 panics when auto-updates disabled

3 participants