Add more deprecation logs and mute by default by sgress454 · Pull Request #40305 · fleetdm/fleet

sgress454 · 2026-02-23T17:13:42Z

Related issue: Resolves #40122

Details

Adds deprecation warnings to fleetctl apply
Adds alias conflict errors (i.e. using both new and deprecated keys in the same spec) to fleetctl apply
Adds logic around all deprecated field warnings to check the topic first
Disables deprecation warnings by default for fleet serve, fleetctl gitops and fleetctl apply
Enables deprecation warnings for dogfood via env var

To turn on warnings:

In fleet serve, use either --logging_enable_topics=deprecated-field-names or the FLEET_LOGGING_ENABLE_TOPICS=deprecated-field-names env var
In fleetctl gitops / fleetctl apply use either --enable-log-topics=deprecated-field-names or FLEET_ENABLE_LOG_TOPICS=deprecated-field-names

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
See Changes files for more information.

Testing

Added/updated automated tests
QA'd all new/changed functionality manually

tested in fleetctl apply, fleet serve and fleet gitops that warnings are suppressed by default and added when the appropriate env var or CLI option is used

sgress454 · 2026-02-23T17:16:51Z

    OTEL_EXPORTER_OTLP_ENDPOINT   = "https://otlp.signoz.dogfood.fleetdm.com"
    # FLEET_LOGGING_TRACING_ENABLED              = "true"
    # FLEET_LOGGING_TRACING_TYPE                 = "elasticapm"
+    FLEET_LOGGING_ENABLE_TOPICS = "deprecated-field-names"


@rfairburn I think this is the right place to add an env var for our Dogfood server, let me know if there's a different place I need to change. This will turn on deprecation warnings on Dogfood so we can see them. The warnings will be turned off by default for the upcoming release.

sgress454 · 2026-02-23T17:19:15Z

 // key names back to old (json tag) names so that structs can be unmarshaled
 // correctly when input uses the new key names.
-func rewriteNewToOldKeys(raw json.RawMessage, target any) json.RawMessage {
+func rewriteNewToOldKeys(raw json.RawMessage, target any) (json.RawMessage, map[string]string, error) {


Updated to return the set of deprecated keys used, if any, for use in warning logs.

sgress454 · 2026-02-23T17:20:34Z


 // GroupFromBytes parses a Group from concatenated YAML specs.
-func GroupFromBytes(b []byte) (*Group, error) {
+func GroupFromBytes(b []byte, options ...GroupFromBytesOpts) (*Group, error) {


Added optional param so that you can send a logger in to GroupFromBytes, which is a more centralized place to log deprecation warnings. Passing the deprecated keys back to the caller would mean having to implement the same logs in several places.

rfairburn

Terraform change looks fine

codecov · 2026-02-23T19:29:26Z

Codecov Report

❌ Patch coverage is 79.76190% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.37%. Comparing base (b0cc888) to head (74c2cbb).
⚠️ Report is 39 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/spec/spec.go	78.04%	5 Missing and 4 partials ⚠️
server/service/appconfig.go	40.00%	5 Missing and 1 partial ⚠️
cmd/fleet/serve.go	0.00%	1 Missing ⚠️
server/platform/endpointer/json_key_rewriter.go	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #40305      +/-   ##
==========================================
+ Coverage   66.28%   66.37%   +0.09%     
==========================================
  Files        2459     2456       -3     
  Lines      196811   196815       +4     
  Branches     8714     8577     -137     
==========================================
+ Hits       130451   130643     +192     
+ Misses      54542    54349     -193     
- Partials    11818    11823       +5

Flag	Coverage Δ
backend	`68.14% <79.76%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iansltx

Minor feedback/questions here. Quessing the reason for having to gate topics this way is we have a number of cases where we're using a very basic logFn rather than slog? Are there any places where the built-in topic handling actually benefits us?

sgress454 · 2026-02-23T21:28:54Z

Updated to use t.Setenv and split test as suggested.

sgress454 · 2026-02-23T22:00:41Z

@rfairburn can you re-👍 when you have a sec? (no changes to the terraform stuff)

**Related issue:** Resolves #40122 # Details * Adds deprecation warnings to `fleetctl apply` * Adds alias conflict errors (i.e. using both new and deprecated keys in the same spec) to `fleetctl apply` * Adds logic around all deprecated field warnings to check the topic first * Disables deprecation warnings by default for `fleet serve`, `fleetctl gitops` and `fleetctl apply` * Enables deprecation warnings for dogfood via env var To turn on warnings: * In `fleet serve`, use either `--logging_enable_topics=deprecated-field-names` or the `FLEET_LOGGING_ENABLE_TOPICS=deprecated-field-names` env var * In `fleetctl gitops` / `fleetctl apply` use either `--enable-log-topics=deprecated-field-names` or `FLEET_ENABLE_LOG_TOPICS=deprecated-field-names` # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [X] Added/updated automated tests - [X] QA'd all new/changed functionality manually tested in `fleetctl apply`, `fleet serve` and `fleet gitops` that warnings are suppressed by default and added when the appropriate env var or CLI option is used (cherry picked from commit 772fb12)

…40394) Cherry pick of #40305 to 4.82.0. (cherry picked from commit 772fb12)

sgress454 added 12 commits February 23, 2026 08:13

initial implementation

65b2ee3

modernize

f51a3b3

Add ability to set log topic by attribute

6739dfc

remove topic context

0beb3d5

mute logs

b56f3f8

disable deprecation warnings for now

d8bd471

Add apply and appconfig deprecation logs

034fb56

remove dead code

64ca1d2

add more deprecation logs, turn off by default, turn on for dogfood

7f72827

use constant, enable warnings in tests

c8f6ce2

test fixes

2d0315b

changelog

8c17b2e

sgress454 requested review from a team, BCTBB, ddribeiro, edwardsb, georgekarrv, ksatter and rfairburn as code owners February 23, 2026 17:13

sgress454 temporarily deployed to Docker Hub February 23, 2026 17:13 — with GitHub Actions Inactive

sgress454 marked this pull request as draft February 23, 2026 17:14

sgress454 commented Feb 23, 2026

View reviewed changes

Comment thread cmd/fleet/serve.go

sgress454 commented Feb 23, 2026

View reviewed changes

Comment thread cmd/fleetctl/fleetctl/apply.go

sgress454 commented Feb 23, 2026

View reviewed changes

Comment thread cmd/fleetctl/fleetctl/gitops.go

sgress454 commented Feb 23, 2026

View reviewed changes

sort warnings for deterministic tests

0a40cf1

sgress454 temporarily deployed to Docker Hub February 23, 2026 17:40 — with GitHub Actions Inactive

sgress454 marked this pull request as ready for review February 23, 2026 17:56

Merge branch 'main' into sgress454/40122-mute-deprecation-logs

578b048

sgress454 temporarily deployed to Docker Hub February 23, 2026 17:56 — with GitHub Actions Inactive

rfairburn previously approved these changes Feb 23, 2026

View reviewed changes

sgress454 assigned iansltx Feb 23, 2026

iansltx reviewed Feb 23, 2026

View reviewed changes

Comment thread changes/40122-mute-deprecation-warnings Outdated

remove changelog

8c86f75

sgress454 dismissed rfairburn’s stale review via 8c86f75 February 23, 2026 19:49

sgress454 temporarily deployed to Docker Hub February 23, 2026 19:49 — with GitHub Actions Inactive

iansltx reviewed Feb 23, 2026

View reviewed changes

sgress454 added 2 commits February 23, 2026 15:24

use t.Setenv

2be5805

move app alias conflict test

74c2cbb

sgress454 temporarily deployed to Docker Hub February 23, 2026 21:27 — with GitHub Actions Inactive

iansltx approved these changes Feb 23, 2026

View reviewed changes

rfairburn approved these changes Feb 23, 2026

View reviewed changes

sgress454 merged commit 772fb12 into main Feb 24, 2026
53 checks passed

sgress454 deleted the sgress454/40122-mute-deprecation-logs branch February 24, 2026 05:09

sgress454 mentioned this pull request Feb 24, 2026

Cherry pick to 4.82: add more deprecation logs and mute by default #40394

Merged

sgress454 added a commit that referenced this pull request Feb 24, 2026

Cherry pick to 4.82: add more deprecation logs and mute by default (#…

84852f0

…40394) Cherry pick of #40305 to 4.82.0. (cherry picked from commit 772fb12)

Conversation

sgress454 commented Feb 23, 2026

Details

Checklist for submitter

Testing

Uh oh!

sgress454 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

rfairburn Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sgress454 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

sgress454 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

rfairburn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iansltx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sgress454 commented Feb 23, 2026

Uh oh!

sgress454 commented Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Feb 23, 2026 •

edited

Loading