Skip to content

Migrate some 'Query' occurrences to 'Report'#40320

Merged
nulmete merged 3 commits intomainfrom
nulmete/migrate-query-occurrences-to-reports
Feb 23, 2026
Merged

Migrate some 'Query' occurrences to 'Report'#40320
nulmete merged 3 commits intomainfrom
nulmete/migrate-query-occurrences-to-reports

Conversation

@nulmete
Copy link
Copy Markdown
Member

@nulmete nulmete commented Feb 23, 2026

Observed some places where we still show Query instead of Report:

Screenshot 2026-02-23 at 3 54 38 PM Screenshot 2026-02-23 at 3 54 49 PM

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests

  • QA'd all new/changed functionality manually

Screenshot 2026-02-23 at 4 13 09 PM Screenshot 2026-02-23 at 5 11 34 PM

@nulmete nulmete marked this pull request as ready for review February 23, 2026 19:16
@nulmete nulmete requested a review from a team as a code owner February 23, 2026 19:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.28%. Comparing base (3d81a21) to head (a5e3061).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #40320    +/-   ##
========================================
  Coverage   66.28%   66.28%            
========================================
  Files        2459     2459            
  Lines      196811   196811            
  Branches     8572     8714   +142     
========================================
  Hits       130451   130451            
+ Misses      54543    54542     -1     
- Partials    11817    11818     +1     
Flag Coverage Δ
frontend 54.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgress454 sgress454 added the ~unreleased bug This bug was found in an unreleased version of Fleet. label Feb 23, 2026
@sgress454 sgress454 added this to the 4.82.0 milestone Feb 23, 2026
@sgress454 sgress454 moved this to 🐥 Review/QA in 💖 #g-first-impressions Feb 23, 2026
@sgress454 sgress454 moved this from 🐥 Review/QA to 🐣 In progress in 💖 #g-first-impressions Feb 23, 2026
@sgress454
Copy link
Copy Markdown
Contributor

Thank you! We'll want to cherry-pick this to 4.82 as well.

sgress454
sgress454 previously approved these changes Feb 23, 2026
@sgress454 sgress454 self-requested a review February 23, 2026 20:00
@nulmete nulmete merged commit 311999f into main Feb 23, 2026
9 checks passed
@nulmete nulmete deleted the nulmete/migrate-query-occurrences-to-reports branch February 23, 2026 20:18
@sgress454 sgress454 moved this from 🐣 In progress to 🐥 Review/QA in 💖 #g-first-impressions Feb 23, 2026
sgress454 pushed a commit that referenced this pull request Feb 26, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
Observed some places where we still show Query instead of Report:

<img width="1557" height="689" alt="Screenshot 2026-02-23 at 3 54 38 PM"
src="https://github.com/user-attachments/assets/df677e6a-05a3-4d5c-8751-b6f25f845c31"
/>
<img width="2521" height="496" alt="Screenshot 2026-02-23 at 3 54 49 PM"
src="https://github.com/user-attachments/assets/a0c706cf-49b9-410e-919a-2482589114c3"
/>

# Checklist for submitter

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

## Testing

- [x] Added/updated automated tests

- [x] QA'd all new/changed functionality manually

<img width="1496" height="666" alt="Screenshot 2026-02-23 at 4 13 09 PM"
src="https://github.com/user-attachments/assets/de0ed5bc-8156-42f4-9428-b2477ea8c90d"
/>

<img width="2547" height="562" alt="Screenshot 2026-02-23 at 5 11 34 PM"
src="https://github.com/user-attachments/assets/e9d55b93-8221-43d8-9ffe-cc2e8de433f5"
/>

(cherry picked from commit 311999f)
sgress454 added a commit that referenced this pull request Feb 26, 2026
)

Cherry-pick of #40320 into `rc-minor-fleet-v4.82.0`.

Co-authored-by: Nico <32375741+nulmete@users.noreply.github.com>
@sgress454 sgress454 moved this from 🐥 In review to Awaiting QA in 💖 #g-first-impressions Feb 26, 2026
@georgekarrv georgekarrv mentioned this pull request Mar 3, 2026
@Brajim20
Copy link
Copy Markdown
Member

Brajim20 commented Mar 5, 2026

Tested on Version 4.82.0
chrome-capture-2026-03-05 (1)
chrome-capture-2026-03-05 (2)

@Brajim20 Brajim20 moved this from Awaiting QA to Done in 💖 #g-first-impressions Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~unreleased bug This bug was found in an unreleased version of Fleet.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants