Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #40364 +/- ##
==========================================
- Coverage 66.27% 66.27% -0.01%
==========================================
Files 2459 2460 +1
Lines 197073 197340 +267
Branches 8572 8572
==========================================
+ Hits 130614 130786 +172
- Misses 54636 54706 +70
- Partials 11823 11848 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgress454
commented
Feb 24, 2026
| err = fleet.NewInvalidArgumentError("script", err.Error()).WithStatus(http.StatusConflict) // TODO: confirm error message with product/frontend | ||
| } else if errors.As(err, &fkErr) { | ||
| err = fleet.NewInvalidArgumentError("team_id", "The team does not exist.").WithStatus(http.StatusNotFound) | ||
| err = fleet.NewInvalidArgumentError("team_id/fleet_id", "The fleet does not exist.").WithStatus(http.StatusNotFound) |
Contributor
Author
There was a problem hiding this comment.
At this point, we don't know what key they actually used. So I'm just listing both. These are server logs, not user-facing, and they'll go away in Fleet 5.
iansltx
reviewed
Feb 25, 2026
iansltx
reviewed
Feb 25, 2026
Contributor
iansltx
left a comment
iansltx
left a comment
There was a problem hiding this comment.
Couple minor wording tweaks, but reasonable on the whole
Contributor
Author
|
Addressed feedback, good finds! |
iansltx
approved these changes
Feb 25, 2026
Contributor
iansltx
left a comment
iansltx
left a comment
There was a problem hiding this comment.
Thx for the cleanup! LGTM.
sgress454
added a commit
that referenced
this pull request
Feb 26, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** For #40348 # Details This PR updates a number of error message on the server to use `fleet` and `report` instead of `team` or `query` where applicable. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. this is all internal, i don't think it warrants a changelog ## Testing - [X] Added/updated automated tests - [ ] QA'd all new/changed functionality manually I did not go trying to trigger all these errors. It's text changes.
iansltx
pushed a commit
that referenced
this pull request
Feb 26, 2026
Cherry-pick of #40364 into `rc-minor-fleet-v4.82.0`.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: For #40348
Details
This PR updates a number of error message on the server to use
fleetandreportinstead ofteamorquerywhere applicable.Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
this is all internal, i don't think it warrants a changelog
Testing
I did not go trying to trigger all these errors. It's text changes.