Allow "unassigned.yml" in GitOps by sgress454 · Pull Request #40414 · fleetdm/fleet

sgress454 · 2026-02-24T18:23:43Z

Related issue: For #40433

Details

This PR updates fleetctl gitops and fleetctl generate_gitops to use unassigned.yml in place of no-team.yml. The two files are utilized identically, except that unassigned.yml expects the name: to be Unassigned rather than No team.

Internally, we still map some things to the string "no team" before sending to the back end so that we don't have to update back-end code and make more spaghetti to clean up when we 🔪 No Team as a concept in Fleet 5.

We do pass the filename into the main DoGitOps method, but both I and Claude did our best to determine that it's not used in any way that would break with this change.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
See Changes files for more information.

Testing

Added/updated automated tests
QA'd all new/changed functionality manually
From test plan:
With a pre-existing GitOps folder w/ no-team.yml, run fleetctl gitops -f /path/to/no-team.yml --dry-run --enable-log-topics=deprecated-field-names and verify that everything works as expected and you get the deprecation warning.
Do the above without --dry-run and verify via the UI and/or fleetctl generate-gitops that the Fleet config is as expected.
Change no-team.yml to unassigned.yml, try a gitops run with fleetctl gitops -f /path/to/unassigned.yml --dry-run --enable-log-topics=deprecated-field-names and verify that you get an error because the name: is still No team
Change the name: to Unassigned, repeat the run above and verify that the output is the same as with no-team.yml, and that no deprecation warning is listed.
Do the same as the above without --dry-run and verify that the Fleet config is as expected.
Run fleetctl generate-gitops and verify that unassigned.yml is output rather than no-team.yml, and any related files are under the lib/unassigned folder rather than lib/no-team, and any paths inside unassigned.yml (e.g. for scripts) are pointed at lib/unassigned.

New Fleet configuration settings

Verified that the setting is exported via fleetctl generate-gitops
Verified the setting is documented in a separate PR to the GitOps documentation
@noahtalerman will work on this

codecov · 2026-02-24T22:56:17Z

Codecov Report

❌ Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.30%. Comparing base (55e20da) to head (cc5ab97).
⚠️ Report is 89 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/fleetctl/fleetctl/generate_gitops.go	54.54%	5 Missing ⚠️
cmd/fleetctl/fleetctl/gitops.go	90.00%	1 Missing and 1 partial ⚠️
ee/server/service/software_installers.go	0.00%	1 Missing ⚠️
pkg/spec/gitops.go	96.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #40414      +/-   ##
==========================================
+ Coverage   66.27%   66.30%   +0.02%     
==========================================
  Files        2459     2465       +6     
  Lines      197172   197448     +276     
  Branches     8715     8715              
==========================================
+ Hits       130677   130916     +239     
- Misses      54668    54685      +17     
- Partials    11827    11847      +20

Flag	Coverage Δ
backend	`68.17% <85.48%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iansltx · 2026-02-25T20:39:26Z

+			if result.IsNoTeam() && filepath.Base(filePath) != "no-team.yml" {
+				multiError = multierror.Append(multiError, fmt.Errorf("file %q for No Team must be named 'no-team.yml'", filePath))
+				multiError = multierror.Append(multiError, errors.New("no-team.yml is deprecated; please rename the file to 'unassigned.yml' and update the team name to 'Unassigned'."))
 			}
+			if result.IsUnassignedTeam() && filepath.Base(filePath) != "unassigned.yml" {
+				multiError = multierror.Append(multiError, fmt.Errorf("file %q for unassigned hosts must be named 'unassigned.yml'", filePath))
+			}


Seems like these should be switch cases above the IsNoTeam || IsUnAssignedTeam checks, returning after appending the errors, rather than falling through.

good call, will update

iansltx · 2026-02-25T20:41:57Z

+func isUnassignedTeam(teamName string) bool {
+	return strings.EqualFold(teamName, unassignedTeamName)
+}


This, and the comparable isNoTeam, should be folded into the *GitOps method rather than split out, given that it's a one-liner that's used in exactly one place.

yeah i was just following a pattern but it's a silly pattern, will fix

Co-authored-by: Ian Littman <iansltx@gmail.com>

@noahtalerman

**Related issue:** For #40433 # Details This PR updates `fleetctl gitops` and `fleetctl generate_gitops` to use `unassigned.yml` in place of `no-team.yml`. The two files are utilized identically, except that `unassigned.yml` expects the `name:` to be `Unassigned` rather than `No team`. Internally, we still map some things to the string "no team" before sending to the back end so that we don't have to update back-end code and make more spaghetti to clean up when we 🔪 No Team as a concept in Fleet 5. We do pass the filename into the main `DoGitOps` method, but both I and Claude did our best to determine that it's not used in any way that would break with this change. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [X] Added/updated automated tests - [X] QA'd all new/changed functionality manually From test plan: - [X] With a pre-existing GitOps folder w/ `no-team.yml`, run `fleetctl gitops -f /path/to/no-team.yml --dry-run --enable-log-topics=deprecated-field-names` and verify that everything works as expected and you get the deprecation warning. - [X] Do the above without `--dry-run` and verify via the UI and/or `fleetctl generate-gitops` that the Fleet config is as expected. - [X] Change `no-team.yml` to `unassigned.yml`, try a gitops run with `fleetctl gitops -f /path/to/unassigned.yml --dry-run --enable-log-topics=deprecated-field-names` and verify that you get an error because the `name:` is still `No team` - [X] Change the `name:` to `Unassigned`, repeat the run above and verify that the output is the same as with `no-team.yml`, and that no deprecation warning is listed. - [X] Do the same as the above without `--dry-run` and verify that the Fleet config is as expected. - [X] Run `fleetctl generate-gitops` and verify that `unassigned.yml` is output rather than `no-team.yml`, and any related files are under the `lib/unassigned` folder rather than `lib/no-team`, and any paths inside `unassigned.yml` (e.g. for scripts) are pointed at `lib/unassigned`. ## New Fleet configuration settings - [X] Verified that the setting is exported via `fleetctl generate-gitops` - [ ] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) @noahtalerman will work on this --------- Co-authored-by: Ian Littman <iansltx@gmail.com>

Cherry-pick of #40414 into `rc-minor-fleet-v4.82.0`. Co-authored-by: Ian Littman <iansltx@gmail.com>

allow unassigned.yml in gitops

552331c

sgress454 had a problem deploying to Docker Hub February 24, 2026 18:23 — with GitHub Actions Error

rename

b06e114

sgress454 temporarily deployed to Docker Hub February 24, 2026 18:31 — with GitHub Actions Inactive

fix tests

dca3ff6

sgress454 temporarily deployed to Docker Hub February 24, 2026 18:49 — with GitHub Actions Inactive

more validation + tests

cb78401

sgress454 temporarily deployed to Docker Hub February 24, 2026 19:50 — with GitHub Actions Inactive

changelog

16f668d

sgress454 temporarily deployed to Docker Hub February 24, 2026 20:06 — with GitHub Actions Inactive

sgress454 marked this pull request as ready for review February 24, 2026 20:08

sgress454 requested a review from a team as a code owner February 24, 2026 20:08

sgress454 assigned iansltx and unassigned iansltx Feb 24, 2026

lint

03fec62

sgress454 temporarily deployed to Docker Hub February 24, 2026 21:40 — with GitHub Actions Inactive

sgress454 added this to the 4.82.0 milestone Feb 24, 2026

update deprecation warnings

a51efd5

sgress454 temporarily deployed to Docker Hub February 25, 2026 02:58 — with GitHub Actions Inactive

sgress454 commented Feb 25, 2026

View reviewed changes

Comment thread cmd/fleetctl/fleetctl/gitops.go

sgress454 commented Feb 25, 2026

View reviewed changes

Comment thread pkg/spec/gitops.go

iansltx reviewed Feb 25, 2026

View reviewed changes

Apply suggestions from code review

27caf31

Co-authored-by: Ian Littman <iansltx@gmail.com>

sgress454 had a problem deploying to Docker Hub February 25, 2026 22:14 — with GitHub Actions Error

Apply suggestion from @sgress454

816543a

sgress454 temporarily deployed to Docker Hub February 25, 2026 22:14 — with GitHub Actions Inactive

feedback from ian

e91fd7c

sgress454 temporarily deployed to Docker Hub February 25, 2026 22:34 — with GitHub Actions Inactive

iansltx previously approved these changes Feb 26, 2026

View reviewed changes

update error msg and test

cc5ab97

sgress454 dismissed iansltx’s stale review via cc5ab97 February 26, 2026 04:13

sgress454 temporarily deployed to Docker Hub February 26, 2026 04:13 — with GitHub Actions Inactive

iansltx approved these changes Feb 26, 2026

View reviewed changes

sgress454 merged commit 10c997b into main Feb 26, 2026
51 checks passed

sgress454 deleted the sgress454/update-gitops-to-support-unassigned.yml branch February 26, 2026 13:47

sgress454 mentioned this pull request Feb 26, 2026

Cherry-pick #40414: Allow "unassigned.yml" in GitOps #40617

Merged

sgress454 added a commit that referenced this pull request Feb 26, 2026

Cherry-pick #40414: Allow "unassigned.yml" in GitOps (#40617)

115390f

Cherry-pick of #40414 into `rc-minor-fleet-v4.82.0`. Co-authored-by: Ian Littman <iansltx@gmail.com>

lukeheath mentioned this pull request Feb 28, 2026

fix sso callback cookie #40763

Closed

georgekarrv mentioned this pull request Mar 3, 2026

gkarr cp 81.1 fixes #40889

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow "unassigned.yml" in GitOps#40414

Allow "unassigned.yml" in GitOps#40414
sgress454 merged 11 commits intomainfrom
sgress454/update-gitops-to-support-unassigned.yml

sgress454 commented Feb 24, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iansltx Feb 25, 2026

Uh oh!

sgress454 Feb 25, 2026

Uh oh!

iansltx Feb 25, 2026

Uh oh!

sgress454 Feb 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sgress454 commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Checklist for submitter

Testing

New Fleet configuration settings

Uh oh!

codecov Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iansltx Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

sgress454 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

iansltx Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

sgress454 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sgress454 commented Feb 24, 2026 •

edited

Loading

codecov Bot commented Feb 24, 2026 •

edited

Loading