Conversation
nulmete
commented
Feb 24, 2026
Comment on lines
+18
to
+20
| return ( | ||
| selectableRows.length > 0 && selectableRows.every((row) => row.isSelected) | ||
| ); |
Member
Author
There was a problem hiding this comment.
probably an existing bug; every returns true for empty arrays
nulmete
commented
Feb 24, 2026
Comment on lines
+98
to
+106
| // Hide the selection column if the current page has no selectable rows | ||
| // (e.g., all rows are inherited policies that can't be selected) | ||
| const pageHasSelectableRows = | ||
| !viewingTeamPolicies || | ||
| isPrimoMode || | ||
| policiesList.some((p) => p.team_id !== null); | ||
|
|
||
| const hasPermissionAndPoliciesToDelete = | ||
| canAddOrDeletePolicies && hasPoliciesToDelete; | ||
| canAddOrDeletePolicies && hasPoliciesToDelete && pageHasSelectableRows; |
Member
Author
There was a problem hiding this comment.
we have this pattern in the Reports page so I decided to follow that.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40435 +/- ##
==========================================
- Coverage 66.27% 66.26% -0.02%
==========================================
Files 2461 2460 -1
Lines 197510 197230 -280
Branches 8754 8655 -99
==========================================
- Hits 130902 130691 -211
+ Misses 54762 54714 -48
+ Partials 11846 11825 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nulmete
deleted the
nulmete/manage-automations-queries-policies-followup
branch
nulmete
added a commit
that referenced
this pull request
Feb 25, 2026
… visible as admin (#40435) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #25080 (specifically this comment #25080 (comment)) # Checklist for submitter - [x] Changes file added (has already been added as part of previous PRs). ## Testing - [x] QA'd all new/changed functionality manually https://github.com/user-attachments/assets/e9d1e38c-8a6d-4cc9-9af2-a1466ba3454f
nulmete
added a commit
that referenced
this pull request
Feb 25, 2026
… visible as admin (#40435) (#40479) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> Already merged to main. **Related issue:** Resolves #25080 (specifically this comment #25080 (comment)) # Checklist for submitter - [x] Changes file added (has already been added as part of previous PRs). ## Testing - [x] QA'd all new/changed functionality manually https://github.com/user-attachments/assets/e9d1e38c-8a6d-4cc9-9af2-a1466ba3454f
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #25080 (specifically this comment #25080 (comment))
Checklist for submitter
Testing
Screen.Recording.2026-02-24.at.6.10.25.PM.mov