Skip to content

Fleet UI: Add 10 per page to install software setup#40505

Merged
RachelElysia merged 4 commits intomainfrom
37828-add-pagination
Feb 27, 2026
Merged

Fleet UI: Add 10 per page to install software setup#40505
RachelElysia merged 4 commits intomainfrom
37828-add-pagination

Conversation

@RachelElysia
Copy link
Copy Markdown
Member

@RachelElysia RachelElysia commented Feb 25, 2026

Issue

Followup for #37828

Description

  • Design update to add pagination to design of 4.82 feature
  • 10 per page
  • Checked items persist across pages

Screen recording of pagination

Screen.Recording.2026-02-25.at.11.48.17.AM.mov

Selections persists with filters and pagination
https://github.com/user-attachments/assets/7168cf62-0eef-4d16-b066-e3e5e05e8765

Testing

  • QA'd all new/changed functionality manually

software.app_store_app?.install_during_setup
) {
acc[i] = true;
if (software.id != null) {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needed to change because

  • When you paginate or filter, rows move to different indices.
  • React‑table still uses the original index keys for selectedRowIds, so the checkboxes no longer line up with the same software items.

cdcme
cdcme previously approved these changes Feb 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.25%. Comparing base (2d5b516) to head (84edd60).
⚠️ Report is 106 commits behind head on main.

Files with missing lines Patch % Lines
.../components/TableContainer/DataTable/DataTable.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40505      +/-   ##
==========================================
- Coverage   66.26%   66.25%   -0.01%     
==========================================
  Files        2461     2461              
  Lines      197427   197411      -16     
  Branches     8763     8767       +4     
==========================================
- Hits       130832   130803      -29     
- Misses      54749    54762      +13     
  Partials    11846    11846              
Flag Coverage Δ
frontend 54.05% <71.42%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RachelElysia RachelElysia merged commit 44cf3c2 into main Feb 27, 2026
19 checks passed
@RachelElysia RachelElysia deleted the 37828-add-pagination branch February 27, 2026 15:29
iansltx pushed a commit that referenced this pull request Feb 27, 2026
… (#40694)

## Issue
Follow-up design request for #37828 

## Description
Previously merged into `main` with #40505 
This is for the 4.82 R.C. branch

```
 1372  git checkout fleetdm/rc-minor-fleet-v4.82.0
 1373  git checkout -b 37828-add-pagination-rc
 1374  git log main
 1375  git cherry-pick 44cf3c2
 1376  git push -u fleetdm 37828-add-pagination-rc
```
@georgekarrv georgekarrv mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants