Match Windows Fleet maintained apps by similar name#40544
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40544 +/- ##
==========================================
+ Coverage 66.27% 66.29% +0.02%
==========================================
Files 2461 2466 +5
Lines 197427 197559 +132
Branches 8618 8618
==========================================
+ Hits 130842 130981 +139
+ Misses 54740 54732 -8
- Partials 11845 11846 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdcme
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #37802
Attempt to fix Windows FMAs not showing up as available when the software titles they match to have upgrade codes. Since we don't surface upgrade codes in the
fleet_maintained_appstable and matching exactly by name could miss some cases, this fix usesteam_titles.name LIKE CONCAT(LEAST(fma.name, fma.unique_identifier), '%'). Note the LEAST there is only for the "Box Drive" app which has a longer name than unique_identifier, and just compares the strings and not their length.This isn't optimal for performance or correctness, but it only checks with titles already available to the team as installers so it shouldn't be terrible. Until upgrade_code is surfaced in the
fleet_maintained_appstable this should be sufficient.Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually