Skip to content

Match Windows Fleet maintained apps by similar name#40544

Merged
jkatz01 merged 9 commits intomainfrom
37802-match-by-name
Feb 26, 2026
Merged

Match Windows Fleet maintained apps by similar name#40544
jkatz01 merged 9 commits intomainfrom
37802-match-by-name

Conversation

@jkatz01
Copy link
Copy Markdown
Member

@jkatz01 jkatz01 commented Feb 25, 2026

Related issue: Resolves #37802
Attempt to fix Windows FMAs not showing up as available when the software titles they match to have upgrade codes. Since we don't surface upgrade codes in the fleet_maintained_apps table and matching exactly by name could miss some cases, this fix uses team_titles.name LIKE CONCAT(LEAST(fma.name, fma.unique_identifier), '%'). Note the LEAST there is only for the "Box Drive" app which has a longer name than unique_identifier, and just compares the strings and not their length.

This isn't optimal for performance or correctness, but it only checks with titles already available to the team as installers so it shouldn't be terrible. Until upgrade_code is surfaced in the fleet_maintained_apps table this should be sufficient.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.29%. Comparing base (6dd1848) to head (1c6542a).
⚠️ Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40544      +/-   ##
==========================================
+ Coverage   66.27%   66.29%   +0.02%     
==========================================
  Files        2461     2466       +5     
  Lines      197427   197559     +132     
  Branches     8618     8618              
==========================================
+ Hits       130842   130981     +139     
+ Misses      54740    54732       -8     
- Partials    11845    11846       +1     
Flag Coverage Δ
backend 68.17% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkatz01 jkatz01 marked this pull request as ready for review February 26, 2026 16:28
@jkatz01 jkatz01 requested a review from a team as a code owner February 26, 2026 16:28
@jkatz01 jkatz01 merged commit 3abdf74 into main Feb 26, 2026
46 checks passed
@jkatz01 jkatz01 deleted the 37802-match-by-name branch February 26, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Fleet-maintained apps: After a Fleet-maintained app is added to a team it shouldn't be available to add again

2 participants