Cherry-pick #40351: Use "unassigned" in place of "no teams"#40619
Merged
iansltx merged 1 commit intorc-minor-fleet-v4.82.0from Feb 26, 2026
Merged
Cherry-pick #40351: Use "unassigned" in place of "no teams"#40619iansltx merged 1 commit intorc-minor-fleet-v4.82.0from
iansltx merged 1 commit intorc-minor-fleet-v4.82.0from
Conversation
…checks and messages (#40351) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** For #40348 # Details This PR replaces the use of "No team" with "Unassigned" and "All teams" with "All fleets" in appropriate checks and error messages. Specifically it restricts using "All fleets" or "Unassigned" as team names # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. n/a ## Testing - [X] Added/updated automated tests - [X] QA'd all new/changed functionality manually * tested attempting to add "no team", "all teams", "unassigned" and "all fleets" as teams and saw appropriate error message
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.82.0 #40619 +/- ##
=========================================================
Coverage ? 66.38%
=========================================================
Files ? 2457
Lines ? 197102
Branches ? 8730
=========================================================
Hits ? 130843
Misses ? 54425
Partials ? 11834
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iansltx
approved these changes
Feb 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #40351 into
rc-minor-fleet-v4.82.0.