Log orphan MDM command references instead of returning 500#40877
Merged
Log orphan MDM command references instead of returning 500#40877
Conversation
nulmete
commented
Mar 3, 2026
|
|
||
| // for ADE enrolled iDevices, we don't advance to "locked" until we have location data | ||
| if hostPlatform == "ios" || hostPlatform == "ipados" { | ||
| if status.LockMDMCommand != nil && (hostPlatform == "ios" || hostPlatform == "ipados") { |
Member
Author
There was a problem hiding this comment.
guarding against the orphan case where cmd is nil (without this, LocationPending could be incorrectly set to true for iDevices even when no lock command exists)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40877 +/- ##
==========================================
+ Coverage 66.34% 66.36% +0.01%
==========================================
Files 2477 2473 -4
Lines 198425 198140 -285
Branches 8780 8652 -128
==========================================
- Hits 131649 131488 -161
+ Misses 54877 54753 -124
Partials 11899 11899
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lucasmrod
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #36682
getHostScriptExecutionResultDBwithin theGetHostLockWipeStatusfunction for consistency => now return a 404 instead of a 500 when no rows are returned.The actual fix would be to remove the
host_mdm_actionsrecord that contains the orphanlock_refmentioned in the issue.I'm not sure what the root cause is, but I think setting up some monitoring on the logs I added should help determining that.
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
Added/updated automated tests
QA'd all new/changed functionality manually