Skip to content

always show the filters and search bar #41163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahzielv merged 2 commits into from
Mar 9, 2026
Merged

always show the filters and search bar #41163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b163238
always show the filters and search bar
jahzielv Mar 6, 2026
fcca6bb
changes file
jahzielv Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/40327-filter
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Updated host software library to always allow filtering.
10 changes: 2 additions & 8 deletions ...s/details/cards/HostSoftwareLibrary/HostSoftwareLibraryTable/HostSoftwareLibraryTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,6 @@ const HostSoftwareLibraryTable = ({
return <EmptySoftwareTable noSearchQuery={searchQuery === ""} />;
}, [searchQuery]);

// Determines if a user should be able to filter or search in the table
const hasData = data && data.software.length > 0;
const hasQuery = searchQuery !== "";

const showFilterHeaders = hasData || hasQuery;

if (isAndroid(platform)) {
return (
<EmptyTable
Expand Down Expand Up @@ -212,11 +206,11 @@ const HostSoftwareLibraryTable = ({
pageSize={DEFAULT_PAGE_SIZE}
inputPlaceHolder="Search by name"
onQueryChange={onQueryChange}
customControl={showFilterHeaders ? renderCustomControls : undefined}
customControl={renderCustomControls}
emptyComponent={memoizedEmptyComponent}
showMarkAllPages={false}
isAllPagesSelected={false}
searchable={showFilterHeaders}
searchable
manualSortBy
/>
</div>
Expand Down
Loading