DB migration: Add require_all column to installers labels tables#41279
Merged
mna merged 1 commit intofeat-installers-labels-include-allfrom Mar 10, 2026
Merged
Conversation
mna
commented
Mar 9, 2026
| _, err = tx.Exec(`ALTER TABLE vpp_app_team_labels ADD COLUMN require_all BOOL NOT NULL DEFAULT false`) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to add require_all to vpp_app_team_labels: %w", err) | ||
| } |
Member
Author
There was a problem hiding this comment.
We currently support labels_include_any and labels_exclude_any, so there's no data changes needed to existing rows (require_all needs to be set to 0/false for those 2 cases, which will be the case by default).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-installers-labels-include-all #41279 +/- ##
======================================================================
- Coverage 66.34% 66.34% -0.01%
======================================================================
Files 2477 2478 +1
Lines 198439 198454 +15
Branches 8854 8854
======================================================================
+ Hits 131660 131663 +3
- Misses 54877 54883 +6
- Partials 11902 11908 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdcme
approved these changes
Mar 9, 2026
10 tasks
georgekarrv
added a commit
that referenced
this pull request
Mar 19, 2026
- **DB migration: Add `require_all` column to installers labels tables (#41279)** - **Backend: Support labels_include_all for installers/apps (#41324)** - **ui impl for labels include all (#41836)** <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #39916 # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [x] Added/updated automated tests - [x] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [x] QA'd all new/changed functionality manually ## Database migrations - [x] Checked schema for all modified table for columns that will auto-update timestamps during migration. ## New Fleet configuration settings - [x] Verified that the setting is exported via `fleetctl generate-gitops` - [x] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) - [x] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional) - [x] Verified that any relevant UI is disabled when GitOps mode is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: (partially) Resolves #40721
PR for the DB changes only, targeting a feature branch as this is started in the 4.83 sprint but the story will land only in 4.84, so it must not make it to
mainuntil next sprint.Checklist for submitter
Database migrations