Skip to content

Fixed DB lock contention during vulnerability cron's software cleanup that caused failures under load (#41375)#41380

Merged
getvictor merged 1 commit intorc-minor-fleet-v4.82.0from
victor/41374-cherry-pick
Mar 10, 2026
Merged

Fixed DB lock contention during vulnerability cron's software cleanup that caused failures under load (#41375)#41380
getvictor merged 1 commit intorc-minor-fleet-v4.82.0from
victor/41374-cherry-pick

Conversation

@getvictor
Copy link
Copy Markdown
Member

Cherry pick.

Related issue: Resolves #41374

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.

  • QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

  • Alerted the release DRI if additional load testing is needed
  • Bug Fixes
  • Resolved database lock contention that occurred during software cleanup operations, which previously caused failures under heavy load. The cleanup process now uses an optimized batched approach for improved reliability and performance.

… that caused failures under load (#41375)

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #41374

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.

- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Alerted the release DRI if additional load testing is needed

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

* **Bug Fixes**
* Resolved database lock contention that occurred during software
cleanup operations, which previously caused failures under heavy load.
The cleanup process now uses an optimized batched approach for improved
reliability and performance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@getvictor getvictor marked this pull request as ready for review March 10, 2026 18:57
@getvictor getvictor requested a review from a team as a code owner March 10, 2026 18:57
@getvictor getvictor merged commit ed73783 into rc-minor-fleet-v4.82.0 Mar 10, 2026
30 of 32 checks passed
@getvictor getvictor deleted the victor/41374-cherry-pick branch March 10, 2026 19:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.82.0@1acc03b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/software.go 63.63% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.82.0   #41380   +/-   ##
=========================================================
  Coverage                          ?   66.12%           
=========================================================
  Files                             ?     1438           
  Lines                             ?   163205           
  Branches                          ?        0           
=========================================================
  Hits                              ?   107914           
  Misses                            ?    44360           
  Partials                          ?    10931           
Flag Coverage Δ
backend 66.12% <63.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

getvictor added a commit that referenced this pull request Mar 11, 2026
… cleanup that caused failures under load (#41375) (#41380)"

This reverts commit ed73783.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants