Skip to content

Don't resend profiles if IdP values do not change (41239)#41662

Merged
juan-fdz-hawa merged 1 commit intomainfrom
41239-put-hostsiddevice_mapping-should-only-trigger-resend-if-changes
Mar 13, 2026
Merged

Don't resend profiles if IdP values do not change (41239)#41662
juan-fdz-hawa merged 1 commit intomainfrom
41239-put-hostsiddevice_mapping-should-only-trigger-resend-if-changes

Conversation

@juan-fdz-hawa
Copy link
Contributor

Related issue: Resolves #41239

Checklist for submitter

PUT /hosts/{id}/device_mapping should only trigger a resend of profiles when the IdP value changes.

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

PUT /hosts/{id}/device_mapping should only trigger a resend
of profiles when the IdP value changes.
@juan-fdz-hawa juan-fdz-hawa force-pushed the 41239-put-hostsiddevice_mapping-should-only-trigger-resend-if-changes branch from 64c51a3 to dbd3a61 Compare March 13, 2026 17:45
@juan-fdz-hawa
Copy link
Contributor Author

@coderabbitai full review

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.36%. Comparing base (9424db4) to head (dbd3a61).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
server/service/hosts.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #41662   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files        2492     2492           
  Lines      199553   199633   +80     
  Branches     8977     8977           
=======================================
+ Hits       132430   132495   +65     
- Misses      55155    55162    +7     
- Partials    11968    11976    +8     
Flag Coverage Δ
backend 68.17% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juan-fdz-hawa juan-fdz-hawa merged commit 0a00d20 into main Mar 13, 2026
50 checks passed
@juan-fdz-hawa juan-fdz-hawa deleted the 41239-put-hostsiddevice_mapping-should-only-trigger-resend-if-changes branch March 13, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PUT /hosts/{id}/device_mapping should only trigger a resend of profiles when the IdP value changes

2 participants