Skip to content

Cherry pick: Add automation_type filter to count policies endpoint (#42007)#42059

Merged
jkatz01 merged 1 commit intorc-minor-fleet-v4.83.0from
41987-cherry-pick
Mar 19, 2026
Merged

Cherry pick: Add automation_type filter to count policies endpoint (#42007)#42059
jkatz01 merged 1 commit intorc-minor-fleet-v4.83.0from
41987-cherry-pick

Conversation

@jkatz01
Copy link
Member

@jkatz01 jkatz01 commented Mar 19, 2026

Resolves #41987
Introduced to main in #42007

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #41987 

# Checklist for submitter


## Testing

- [x] Added/updated automated tests
- [ ] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually
- Tested with the "scripts" filter and >20 policies with that
automation, and together with #41991 the policy count and pagination is
correct
@jkatz01 jkatz01 marked this pull request as ready for review March 19, 2026 14:31
@jkatz01 jkatz01 requested a review from a team as a code owner March 19, 2026 14:31
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.83.0@3032d70). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/policies.go 75.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.83.0   #42059   +/-   ##
=========================================================
  Coverage                          ?   66.40%           
=========================================================
  Files                             ?     2502           
  Lines                             ?   200878           
  Branches                          ?     8872           
=========================================================
  Hits                              ?   133403           
  Misses                            ?    55415           
  Partials                          ?    12060           
Flag Coverage Δ
backend 68.18% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkatz01 jkatz01 merged commit c98e3f8 into rc-minor-fleet-v4.83.0 Mar 19, 2026
45 of 48 checks passed
@jkatz01 jkatz01 deleted the 41987-cherry-pick branch March 19, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants