Backport to 4.83.0: Use swap table pattern and batch delete to improv…#42300
Merged
JordanMontgomery merged 1 commit intorc-minor-fleet-v4.83.0from Mar 24, 2026
Merged
Backport to 4.83.0: Use swap table pattern and batch delete to improv…#42300JordanMontgomery merged 1 commit intorc-minor-fleet-v4.83.0from
JordanMontgomery merged 1 commit intorc-minor-fleet-v4.83.0from
Conversation
…e DB access patterns for vuln cron (#41729) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #41664 Switching `kernel_host_counts` to the established swap pattern. Reduce load on the DB writer by moving the large read to the DB reader. Do `CleanupSoftwareTitles` in batches. With a single large select/delete, it took > 16 minutes. In batches, it took ~1.5 minutes in loadtest with 100K hosts. If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - [x] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [x] Alerted the release DRI if additional load testing is needed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Performance Improvements** * Added indexing and a batched swap/insert flow to speed up vulnerability-related queries and lower maintenance contention. * Batched cleanup of orphaned records to reduce long-running delete operations. * **Reliability** * Migration removes a legacy constraint to simplify data maintenance and avoid migration failures. * Scheduled vulnerability refresh now runs more atomically to reduce disruption. * **Tests** * Updated assertion logic to improve test clarity for host-count verification. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review.
Tip: disable this comment in your organization's Code Review settings.
getvictor
approved these changes
Mar 24, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.83.0 #42300 +/- ##
=========================================================
Coverage ? 66.40%
=========================================================
Files ? 2503
Lines ? 200948
Branches ? 8872
=========================================================
Hits ? 133442
Misses ? 55441
Partials ? 12065
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6814004
into
rc-minor-fleet-v4.83.0
41 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e DB access patterns for vuln cron (#41729)
Related issue: Resolves #41664
Switching
kernel_host_countsto the established swap pattern. Reduce load on the DB writer by moving the large read to the DB reader.Do
CleanupSoftwareTitlesin batches. With a single large select/delete, it took > 16 minutes. In batches, it took ~1.5 minutes in loadtest with 100K hosts.If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.QA'd all new/changed functionality manually
For unreleased bug fixes in a release candidate, one of:
Performance Improvements
Added indexing and a batched swap/insert flow to speed up vulnerability-related queries and lower maintenance contention.
Batched cleanup of orphaned records to reduce long-running delete operations.
Reliability
Migration removes a legacy constraint to simplify data maintenance and avoid migration failures.
Scheduled vulnerability refresh now runs more atomically to reduce disruption.
Tests
Updated assertion logic to improve test clarity for host-count verification.