Skip to content

Fix: Use display_name instead of name in Android software edit configuration flash message#42384

Closed
kilo-code-bot[bot] wants to merge 3 commits intomainfrom
kilo/fix-android-config-flash-display-name
Closed

Fix: Use display_name instead of name in Android software edit configuration flash message#42384
kilo-code-bot[bot] wants to merge 3 commits intomainfrom
kilo/fix-android-config-flash-display-name

Conversation

@kilo-code-bot
Copy link
Copy Markdown
Contributor

@kilo-code-bot kilo-code-bot bot commented Mar 25, 2026

Resolves: #42383

Built for Marko Lisica by Kilo for Slack

@kilo-code-bot kilo-code-bot bot requested a review from a team as a code owner March 25, 2026 15:30
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

Tip: disable this comment in your organization's Code Review settings.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.51%. Comparing base (1d8e350) to head (5388c45).
⚠️ Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
.../EditConfigurationModal/EditConfigurationModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #42384      +/-   ##
==========================================
- Coverage   66.51%   66.51%   -0.01%     
==========================================
  Files        2528     2528              
  Lines      202788   202789       +1     
  Branches     9025     9026       +1     
==========================================
  Hits       134876   134876              
- Misses      55728    55729       +1     
  Partials    12184    12184              
Flag Coverage Δ
frontend 54.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iansltx
Copy link
Copy Markdown
Member

iansltx commented Mar 27, 2026

@marko-lisica I threw this at Opus 4.6 locally for review and it noticed that we have a getDisplayedSoftwareName helper that we use everywhere, and should be used here as well. Going to close this PR out and self-assign the ticket for that fix since a revision would have the same diff size as the entire PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android software: show display name in success message when configuration is edited

3 participants