Skip to content

Remove husky-based pre-commit formatting#42582

Merged
jacobshandling merged 4 commits intomainfrom
remove-husky
Mar 27, 2026
Merged

Remove husky-based pre-commit formatting#42582
jacobshandling merged 4 commits intomainfrom
remove-husky

Conversation

@jacobshandling
Copy link
Copy Markdown
Contributor

Undoes #42470, which overwrites local git hook configuration

@jacobshandling jacobshandling requested a review from a team as a code owner March 27, 2026 19:48
Copilot AI review requested due to automatic review settings March 27, 2026 19:48
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Husky/lint-staged-based pre-commit formatting setup that was introduced previously, reverting the repo back to not installing/overwriting local git hooks via prepare.

Changes:

  • Removed husky and lint-staged from package.json (including the prepare script and lint-staged config).
  • Deleted the .husky/pre-commit hook that ran yarn lint-staged.
  • Updated yarn.lock to remove the Husky entry (but it still appears to retain lint-staged).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Removes Husky/lint-staged tooling and associated config/scripts.
yarn.lock Removes Husky lock entry (needs follow-up cleanup for lint-staged).
frontend/pages/hosts/ManageHostsPage/ManageHostsPage.tsx Contains unrelated new constants likely added accidentally (currently problematic).
.husky/pre-commit Removes the pre-commit hook that ran formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.65%. Comparing base (27f2be9) to head (7e37628).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #42582    +/-   ##
========================================
  Coverage   66.64%   66.65%            
========================================
  Files        2532     2533     +1     
  Lines      202930   203042   +112     
  Branches     9026     9078    +52     
========================================
+ Hits       135243   135332    +89     
- Misses      55440    55460    +20     
- Partials    12247    12250     +3     
Flag Coverage Δ
frontend 54.43% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@dantecatalfamo dantecatalfamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏃 💨  ☢︎

@jacobshandling jacobshandling merged commit 293b434 into main Mar 27, 2026
16 checks passed
@jacobshandling jacobshandling deleted the remove-husky branch March 27, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants