Skip to content

Rename Apple Business Manager in UI#42584

Merged
melpike merged 11 commits intomainfrom
melpike-rename-ABM-UI-Docs
Apr 8, 2026
Merged

Rename Apple Business Manager in UI#42584
melpike merged 11 commits intomainfrom
melpike-rename-ABM-UI-Docs

Conversation

@melpike
Copy link
Copy Markdown
Member

@melpike melpike commented Mar 27, 2026

Related issue: Resolves #42512

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.86%. Comparing base (8bc84d9) to head (12872d2).
⚠️ Report is 205 commits behind head on main.

Files with missing lines Patch % Lines
cmd/fleet/serve.go 0.00% 3 Missing ⚠️
ee/server/service/vpp.go 66.66% 2 Missing ⚠️
server/fleet/utils.go 0.00% 2 Missing ⚠️
cmd/fleet/cron.go 0.00% 1 Missing ⚠️
cmd/fleetctl/fleetctl/get.go 50.00% 0 Missing and 1 partial ⚠️
ee/server/service/software_installers.go 50.00% 1 Missing ⚠️
frontend/pages/hosts/helpers.ts 0.00% 1 Missing ⚠️
server/mdm/apple/apple_bm.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #42584      +/-   ##
==========================================
+ Coverage   66.81%   66.86%   +0.04%     
==========================================
  Files        2544     2588      +44     
  Lines      204315   207370    +3055     
  Branches     9274     9197      -77     
==========================================
+ Hits       136512   138649    +2137     
- Misses      55429    56119     +690     
- Partials    12374    12602     +228     
Flag Coverage Δ
backend 68.64% <59.25%> (+0.03%) ⬆️
frontend 54.75% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@melpike melpike marked this pull request as ready for review March 27, 2026 20:53
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

lukeheath
lukeheath previously approved these changes Mar 30, 2026
Copy link
Copy Markdown
Member

@lukeheath lukeheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, looks good! I'm going to go ahead and merge to avoid merge conflicts since this touches so many lines.

@lukeheath
Copy link
Copy Markdown
Member

Actually looks like I can't merge. I think we need Rachael's review, I'll tag her.

@noahtalerman noahtalerman marked this pull request as draft March 30, 2026 16:15
@noahtalerman
Copy link
Copy Markdown
Member

FYI @melpike marked this PR as draft so it doesn't get accidentally merged: https://fleetdm.slack.com/archives/C02A8BRABB5/p1774887226760469?thread_ts=1774886445.616329&cid=C02A8BRABB5

@melpike melpike changed the title Rename Apple Business Manager in UI and docs Rename Apple Business Manager in UI Mar 30, 2026
@rachaelshaw rachaelshaw removed their request for review March 31, 2026 20:55
@melpike melpike marked this pull request as ready for review April 1, 2026 19:49
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@melpike melpike requested a review from lukeheath April 2, 2026 14:56
@allenhouchins allenhouchins removed their request for review April 3, 2026 18:46
@MagnusHJensen
Copy link
Copy Markdown
Member

I found a couple more entries that needs updated, once they are updated then we can get this merged:

Message: "Couldn't add software. <app_store_id> isn't available in Apple Business Manager. Please purchase license in Apple Business Manager and try again.",

Message: "Couldn't install. No available licenses. Please purchase license in Apple Business Manager and try again.",

// GetAppleBM retrieves the Apple Business Manager information.

accessible from Apple Business Manager (ABM). Verify the host is

to this host in Apple Business Manager.

@melpike

@melpike
Copy link
Copy Markdown
Member Author

melpike commented Apr 8, 2026

@MagnusHJensen thank you for catching those! I assigned you as reviewer :)

@melpike melpike merged commit 75982f4 into main Apr 8, 2026
66 checks passed
@melpike melpike deleted the melpike-rename-ABM-UI-Docs branch April 8, 2026 17:14
melpike added a commit that referenced this pull request Apr 8, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #42512

---------

Co-authored-by: Luke Heath <luke@fleetdm.com>
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
ksykulev pushed a commit that referenced this pull request Apr 13, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #42512

---------

Co-authored-by: Luke Heath <luke@fleetdm.com>
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Apple Business Manager (ABM) to Apple Business (AB) in UI

4 participants