Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #42584 +/- ##
==========================================
+ Coverage 66.81% 66.86% +0.04%
==========================================
Files 2544 2588 +44
Lines 204315 207370 +3055
Branches 9274 9197 -77
==========================================
+ Hits 136512 138649 +2137
- Misses 55429 56119 +690
- Partials 12374 12602 +228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
lukeheath
left a comment
There was a problem hiding this comment.
Thanks for doing this, looks good! I'm going to go ahead and merge to avoid merge conflicts since this touches so many lines.
|
Actually looks like I can't merge. I think we need Rachael's review, I'll tag her. |
|
FYI @melpike marked this PR as draft so it doesn't get accidentally merged: https://fleetdm.slack.com/archives/C02A8BRABB5/p1774887226760469?thread_ts=1774886445.616329&cid=C02A8BRABB5 |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
I found a couple more entries that needs updated, once they are updated then we can get this merged: fleet/ee/server/service/software_installers.go Line 1469 in 5d51d71 fleet/ee/server/service/software_installers.go Line 1480 in 5d51d71 fleet/server/service/client_mdm.go Line 35 in 5d51d71 |
|
@MagnusHJensen thank you for catching those! I assigned you as reviewer :) |
Related issue: Resolves #42512