Skip to content

use DropdownWrapper for sort dropdown in Host Reports tab#42650

Merged
nulmete merged 4 commits intomainfrom
nulmete/host-reports-tab-sort-dropdown-styling
Mar 31, 2026
Merged

use DropdownWrapper for sort dropdown in Host Reports tab#42650
nulmete merged 4 commits intomainfrom
nulmete/host-reports-tab-sort-dropdown-styling

Conversation

@nulmete
Copy link
Copy Markdown
Member

@nulmete nulmete commented Mar 30, 2026

Related issue: Resolves #41533

Follow-up of this PR after this comment: #42017 (comment)

Checklist for submitter

Changes file already included in previous PR.

Testing

  • QA'd all new/changed functionality manually

Before

Screenshot 2026-03-30 at 11 07 54 AM

After

Screenshot 2026-03-30 at 11 35 49 AM Screenshot 2026-03-30 at 11 35 41 AM

@nulmete nulmete requested a review from a team as a code owner March 30, 2026 14:38
Copilot AI review requested due to automatic review settings March 30, 2026 14:38
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.


@media screen and (max-width: $break-md) {
&__controls {
flex-direction: column-reverse;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw that in the Host list page we put the filters above the host count, so tried to follow a similar pattern

Image

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.69%. Comparing base (82c3983) to head (76b6ecc).
⚠️ Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
...es/hosts/details/HostReportsTab/HostReportsTab.tsx 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #42650      +/-   ##
==========================================
+ Coverage   66.67%   66.69%   +0.02%     
==========================================
  Files        2535     2535              
  Lines      203320   203320              
  Branches     9114     9232     +118     
==========================================
+ Hits       135564   135613      +49     
+ Misses      55490    55441      -49     
  Partials    12266    12266              
Flag Coverage Δ
frontend 54.59% <16.66%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Host details > Reports tab sort control to use the shared DropdownWrapper component, aligning it with other table filter dropdowns and adjusting responsive styling for the controls row.

Changes:

  • Replaces ActionsDropdown with DropdownWrapper for the reports sort selector.
  • Updates sort option typing/handling to use react-select-5’s SingleValue.
  • Refactors Host Reports tab control-row SCSS, including responsive layout tweaks.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
frontend/pages/hosts/details/HostReportsTab/HostReportsTab.tsx Switches sort dropdown implementation from ActionsDropdown to DropdownWrapper and updates sort-change handling.
frontend/pages/hosts/details/HostReportsTab/_styles.scss Adjusts layout/styling for the controls row and dropdown/search sizing, including responsive behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/pages/hosts/details/HostReportsTab/_styles.scss Outdated
Comment thread frontend/pages/hosts/details/HostReportsTab/_styles.scss Outdated
Comment thread frontend/pages/hosts/details/HostReportsTab/HostReportsTab.tsx Outdated
Copy link
Copy Markdown
Member

@RachelElysia RachelElysia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and UI looks great, thank you!

@nulmete nulmete merged commit 99a0413 into main Mar 31, 2026
19 checks passed
@nulmete nulmete deleted the nulmete/host-reports-tab-sort-dropdown-styling branch March 31, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Host details > Reports] Frontend changes

4 participants