use DropdownWrapper for sort dropdown in Host Reports tab#42650
use DropdownWrapper for sort dropdown in Host Reports tab#42650
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
|
||
| @media screen and (max-width: $break-md) { | ||
| &__controls { | ||
| flex-direction: column-reverse; |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42650 +/- ##
==========================================
+ Coverage 66.67% 66.69% +0.02%
==========================================
Files 2535 2535
Lines 203320 203320
Branches 9114 9232 +118
==========================================
+ Hits 135564 135613 +49
+ Misses 55490 55441 -49
Partials 12266 12266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the Host details > Reports tab sort control to use the shared DropdownWrapper component, aligning it with other table filter dropdowns and adjusting responsive styling for the controls row.
Changes:
- Replaces
ActionsDropdownwithDropdownWrapperfor the reports sort selector. - Updates sort option typing/handling to use
react-select-5’sSingleValue. - Refactors Host Reports tab control-row SCSS, including responsive layout tweaks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/pages/hosts/details/HostReportsTab/HostReportsTab.tsx | Switches sort dropdown implementation from ActionsDropdown to DropdownWrapper and updates sort-change handling. |
| frontend/pages/hosts/details/HostReportsTab/_styles.scss | Adjusts layout/styling for the controls row and dropdown/search sizing, including responsive behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RachelElysia
left a comment
There was a problem hiding this comment.
Code and UI looks great, thank you!

Related issue: Resolves #41533
Follow-up of this PR after this comment: #42017 (comment)
Checklist for submitter
Changes file already included in previous PR.
Testing
Before
After