Update label immutable text to use default body text styling#42851
Closed
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Closed
Update label immutable text to use default body text styling#42851kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
Replace help-text mixin (12px grey text) with standard body text styles (14px, default body color) for the immutable fields notice on the edit labels page.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42851 +/- ##
==========================================
- Coverage 66.81% 66.81% -0.01%
==========================================
Files 2541 2541
Lines 203915 203915
Branches 9279 9164 -115
==========================================
- Hits 136248 136246 -2
- Misses 55329 55331 +2
Partials 12338 12338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nulmete
reviewed
Apr 3, 2026
Comment on lines
+9
to
+10
| font-size: $x-small; | ||
| color: $ui-fleet-black-75; |
Member
|
Duplicate PR, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
help-textmixin<span>to<p>for proper semantic markup and to inherit standard paragraph styles@include help-text(12px font, grey$ui-fleet-black-50color) with explicitfont-size: $x-small(14px) andcolor: $ui-fleet-black-75to match the default body text appearanceChanges
frontend/pages/labels/components/LabelForm/LabelForm.tsx— Changed<span>to<p>elementfrontend/pages/labels/components/LabelForm/_styles.scss— Replaced@include help-textwith standard body text propertiesBuilt for Rachael Shaw by Kilo for Slack