Add MAC address to host vitals display#42867
Conversation
Add primary_mac to HOST_VITALS_DATA constant and display MAC address in the Vitals card on the host details page. Subset of changes from #42773.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42867 +/- ##
========================================
Coverage 66.82% 66.82%
========================================
Files 2544 2544
Lines 204231 204232 +1
Branches 9274 9159 -115
========================================
+ Hits 136474 136475 +1
Misses 55405 55405
Partials 12352 12352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm not sure why it decided to open the same PR 3 times or so |
|
@rachaelshaw looks like this change is already on main (#42773). I'm closing. |
Summary
This PR is a subset of #42773, containing only the changes to display the host's MAC address in the Vitals card on the host details page.
Changes
frontend/pages/hosts/details/cards/Vitals/Vitals.tsx: Added a new "MAC address" entry to the vitals array, displayingvitalsData.primary_macusingTooltipTruncatedText.frontend/utilities/constants.tsx: Added"primary_mac"to theHOST_VITALS_DATAarray so the field is included in the vitals data fetched from the API.Built for Rachael Shaw by Kilo for Slack