Skip to content

Query results table: fix id column header and cell styles#43246

Merged
nulmete merged 1 commit intomainfrom
nulmete/fix-id-table-header-styles
Apr 8, 2026
Merged

Query results table: fix id column header and cell styles#43246
nulmete merged 1 commit intomainfrom
nulmete/fix-id-table-header-styles

Conversation

@nulmete
Copy link
Copy Markdown
Member

@nulmete nulmete commented Apr 8, 2026

Related issue: Resolves #42402

  • Added missing left border to id table header.
  • Changed display: flex to display: table-cell for id table cells.

Checklist for submitter

Testing

  • QA'd all new/changed functionality manually

Before

Screenshot 2026-04-08 at 1 17 34 PM

After

Screenshot 2026-04-08 at 1 17 21 PM

Copilot AI review requested due to automatic review settings April 8, 2026 16:17
@nulmete nulmete requested a review from a team as a code owner April 8, 2026 16:17
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses UI styling issues for query results tables when a query includes an id column, and adds a user-visible release note entry for the fix related to issue #42402.

Changes:

  • Removed special-casing that applied “actions column” header/cell styling to id columns in the shared DataTable styles.
  • Added a changes/ entry documenting the fix.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
frontend/components/TableContainer/DataTable/_styles.scss Stops applying actions__header/actions__cell styling rules to id__header/id__cell.
changes/42402-fix-query-results-deduplication Adds release note entry for the id column query results behavior/style fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1 @@
* Fixed query results table deduplicating rows when query data contains an `id` column, and fixed `id` column header and cell styling.
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes entry uses a * bullet, but other changes/ entries in this repo use - (e.g., changes/34433-speedup-macos-profile-delivery, changes/41603-fix-query-responses). Update this line to use - to match the expected formatting.

Suggested change
* Fixed query results table deduplicating rows when query data contains an `id` column, and fixed `id` column header and cell styling.
- Fixed query results table deduplicating rows when query data contains an `id` column, and fixed `id` column header and cell styling.

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.83%. Comparing base (e55e316) to head (36da644).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #43246      +/-   ##
==========================================
- Coverage   66.83%   66.83%   -0.01%     
==========================================
  Files        2579     2581       +2     
  Lines      206933   207010      +77     
  Branches     9178     9322     +144     
==========================================
+ Hits       138303   138345      +42     
- Misses      56057    56092      +35     
  Partials    12573    12573              
Flag Coverage Δ
frontend 54.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}

&.actions__header,
&.id__header // Same as actions__header on some pages
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't see any table configs having accessor: "id" so that's why I removed id__header and id__cell styles (which were affecting the id column in query results)

@nulmete nulmete merged commit e6357cf into main Apr 8, 2026
20 checks passed
@nulmete nulmete deleted the nulmete/fix-id-table-header-styles branch April 8, 2026 16:28
nulmete added a commit that referenced this pull request Apr 8, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #42402

- Added missing left border to `id` table header.
- Changed `display: flex` to `display: table-cell` for `id` table cells.

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information. (Original PR didn't have one:
#42937.)

## Testing

- [x] QA'd all new/changed functionality manually

#### Before

<img width="1769" height="572" alt="Screenshot 2026-04-08 at 1 17 34 PM"
src="https://github.com/user-attachments/assets/c4131e55-5213-431a-ae81-ffdd8b99fb03"
/>


#### After

<img width="1760" height="572" alt="Screenshot 2026-04-08 at 1 17 21 PM"
src="https://github.com/user-attachments/assets/5e482160-9b5a-4115-bf14-e64e4514e192"
/>
nulmete added a commit that referenced this pull request Apr 8, 2026
ksykulev pushed a commit that referenced this pull request Apr 13, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #42402

- Added missing left border to `id` table header.
- Changed `display: flex` to `display: table-cell` for `id` table cells.

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information. (Original PR didn't have one:
#42937.)

## Testing

- [x] QA'd all new/changed functionality manually

#### Before

<img width="1769" height="572" alt="Screenshot 2026-04-08 at 1 17 34 PM"
src="https://github.com/user-attachments/assets/c4131e55-5213-431a-ae81-ffdd8b99fb03"
/>


#### After

<img width="1760" height="572" alt="Screenshot 2026-04-08 at 1 17 21 PM"
src="https://github.com/user-attachments/assets/5e482160-9b5a-4115-bf14-e64e4514e192"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report UI should display all results when report has id column with non-unique values

3 participants