Query results table: fix id column header and cell styles#43246
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
This PR addresses UI styling issues for query results tables when a query includes an id column, and adds a user-visible release note entry for the fix related to issue #42402.
Changes:
- Removed special-casing that applied “actions column” header/cell styling to
idcolumns in the shared DataTable styles. - Added a
changes/entry documenting the fix.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/components/TableContainer/DataTable/_styles.scss | Stops applying actions__header/actions__cell styling rules to id__header/id__cell. |
| changes/42402-fix-query-results-deduplication | Adds release note entry for the id column query results behavior/style fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1 @@ | |||
| * Fixed query results table deduplicating rows when query data contains an `id` column, and fixed `id` column header and cell styling. | |||
There was a problem hiding this comment.
The changes entry uses a * bullet, but other changes/ entries in this repo use - (e.g., changes/34433-speedup-macos-profile-delivery, changes/41603-fix-query-responses). Update this line to use - to match the expected formatting.
| * Fixed query results table deduplicating rows when query data contains an `id` column, and fixed `id` column header and cell styling. | |
| - Fixed query results table deduplicating rows when query data contains an `id` column, and fixed `id` column header and cell styling. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43246 +/- ##
==========================================
- Coverage 66.83% 66.83% -0.01%
==========================================
Files 2579 2581 +2
Lines 206933 207010 +77
Branches 9178 9322 +144
==========================================
+ Hits 138303 138345 +42
- Misses 56057 56092 +35
Partials 12573 12573
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| &.actions__header, | ||
| &.id__header // Same as actions__header on some pages |
There was a problem hiding this comment.
didn't see any table configs having accessor: "id" so that's why I removed id__header and id__cell styles (which were affecting the id column in query results)
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #42402 - Added missing left border to `id` table header. - Changed `display: flex` to `display: table-cell` for `id` table cells. # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. (Original PR didn't have one: #42937.) ## Testing - [x] QA'd all new/changed functionality manually #### Before <img width="1769" height="572" alt="Screenshot 2026-04-08 at 1 17 34 PM" src="https://github.com/user-attachments/assets/c4131e55-5213-431a-ae81-ffdd8b99fb03" /> #### After <img width="1760" height="572" alt="Screenshot 2026-04-08 at 1 17 21 PM" src="https://github.com/user-attachments/assets/5e482160-9b5a-4115-bf14-e64e4514e192" />
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #42402 - Added missing left border to `id` table header. - Changed `display: flex` to `display: table-cell` for `id` table cells. # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. (Original PR didn't have one: #42937.) ## Testing - [x] QA'd all new/changed functionality manually #### Before <img width="1769" height="572" alt="Screenshot 2026-04-08 at 1 17 34 PM" src="https://github.com/user-attachments/assets/c4131e55-5213-431a-ae81-ffdd8b99fb03" /> #### After <img width="1760" height="572" alt="Screenshot 2026-04-08 at 1 17 21 PM" src="https://github.com/user-attachments/assets/5e482160-9b5a-4115-bf14-e64e4514e192" />
Related issue: Resolves #42402
idtable header.display: flextodisplay: table-cellforidtable cells.Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information. (Original PR didn't have one: Fix query results table deduplicating rows when data contains an
idcolumn #42937.)Testing
Before
After