Cherry-pick #43039: Clean up Gitops tests and add deprecation tests#43255
Conversation
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** For #40015 * Moves repeated empty mocks into a new `setupEmptyGitOpsMocks` method * Adds new "deprecation" tests: * In TestGitOpsFullGlobal, TestGitOpsFullTeam and TestGitOpsFullGlobalAndTeam tests "kitchen sink" with both new and deprecated keys * Added keys and checks to verify `setup_experience`, `apple_business_manager` and `volume_purchasing_program` configs * Consolidated map of deprecated -> new GitOps keys in one place
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.84.0 #43255 +/- ##
=========================================================
Coverage ? 66.85%
=========================================================
Files ? 2578
Lines ? 207038
Branches ? 9246
=========================================================
Hits ? 138415
Misses ? 56022
Partials ? 12601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iansltx
left a comment
iansltx
left a comment
There was a problem hiding this comment.
Good to get this in so we're QA'ing these tweaks alongside the rest of the functionality.
Test failure is unrelated, and succeeded for the other MySQL version, so we're good on CI.
2 participants
Cherry-pick of #43039 into the RC branch.