Rename iMazing Profile Editor to iMazing in the FMA library#43555
Rename iMazing Profile Editor to iMazing in the FMA library#43555allenhouchins merged 1 commit intomainfrom
Conversation
Replace the fleet-maintained app record for "iMazing Profile Editor" with the full "iMazing" app. Deleted the old input file and added a new input for imazing; renamed output paths and updated app metadata (bundle identifier, slug, categories). Bumped version to 3.5.2 and updated installer URL, install/uninstall script refs and SHA256. Updated frontend icon mapping and website routes to point to the new imazing slug, and adjusted fleet configs: workstation software slug, dynamic label query, and macOS patch policy to reference imazing/darwin and the new bundle identifier.
allenhouchins
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Script Diff Resultsee/maintained-apps/inputs/homebrew/imazing-profile-editor.jsonError: File 'ee/maintained-apps/inputs/homebrew/imazing-profile-editor.json' does not existee/maintained-apps/outputs/imazing/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43555 +/- ##
=======================================
Coverage 66.90% 66.90%
=======================================
Files 2600 2600
Lines 208391 208391
Branches 9296 9297 +1
=======================================
Hits 139428 139428
Misses 56276 56276
Partials 12687 12687
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
@eashaw just a small edit to routes.js so no links break due to the FMA name changing. |
There was a problem hiding this comment.
Pull request overview
This PR replaces the fleet-maintained “iMazing Profile Editor” app record with the full “iMazing” app across maintained-app metadata, website routes, frontend icon mapping, and Fleet configuration references.
Changes:
- Introduces a new maintained-app input/output for
imazing/darwinand updatesapps.jsonmetadata (name, slug, bundle identifier, version, URL, scripts, SHA). - Updates Fleet configs (workstation software slug, dynamic label query, and macOS patch policy) to reference the new slug/bundle identifier.
- Updates website and frontend routing/icon mapping to support the new
imazingsoftware-catalog slug (including redirect from the old slug).
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/config/routes.js | Adds software-catalog redirects for imazing and redirects legacy imazing-profile-editor to the new page. |
| it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml | Renames the patch policy and updates it to target imazing/darwin and the new label. |
| it-and-security/lib/all/labels/macs-with-fleet-maintained-apps-installed.yml | Updates the dynamic label to match iMazing’s new bundle identifier. |
| it-and-security/fleets/workstations.yml | Switches the self-service app slug to imazing/darwin. |
| frontend/pages/SoftwarePage/components/icons/index.ts | Updates the icon mapping key to imazing. |
| ee/maintained-apps/outputs/imazing/darwin.json | Updates iMazing versioning, detection queries, installer URL, install/uninstall scripts, and checksum. |
| ee/maintained-apps/outputs/apps.json | Replaces the app listing from “iMazing Profile Editor” to “iMazing” with the new slug and bundle identifier. |
| ee/maintained-apps/inputs/homebrew/imazing.json | Adds the new maintained-app input definition for iMazing. |
| ee/maintained-apps/inputs/homebrew/imazing-profile-editor.json | Removes the old maintained-app input definition for iMazing Profile Editor. |
Comments suppressed due to low confidence (1)
ee/maintained-apps/outputs/imazing/darwin.json:19
- The uninstall script is attempting to quit bundle identifiers that include the version string (e.g.,
com.DigiDNA.iMazing3.5.2.24017Mac/.Mini). This is inconsistent with the app metadata (unique_identifieriscom.DigiDNA.iMazing3Mac) and the install script (which quitscom.DigiDNA.iMazing3Mac). Using versioned bundle IDs will likely fail to quit the running app, leaving it open during uninstall. Update the uninstall script to quit the stable bundle identifiers used elsewhere (and, if needed, the corresponding.Minibundle id).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenhouchins
changed the title
WalkthroughThis change replaces the iMazing Profile Editor app definition with a new iMazing app definition across the codebase. The maintained app version is updated from 2.2.0 to 3.5.2 with a new bundle identifier ( Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
it-and-security/fleets/workstations.yml (1)
317-320: Category mismatch with the new iMazing app definition.The slug has been correctly updated to
imazing/darwin. However, the category remains "Developer tools" while the new iMazing app definition inee/maintained-apps/inputs/homebrew/imazing.jsonspecifies"default_categories": ["Utilities"].iMazing is an iPhone management application (not a profile editor), so "Utilities" would be more accurate. If "Developer tools" is an intentional override for this fleet, please confirm.
💡 Suggested category alignment
- slug: imazing/darwin # iMazing for macOS self_service: true categories: - - Developer tools + - Utilities🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@it-and-security/fleets/workstations.yml` around lines 317 - 320, The categories for the imazing entry (slug: imazing/darwin) in workstations.yml are inconsistent with the maintained app definition; update the categories array for the imazing/darwin entry to ["Utilities"] to match ee/maintained-apps/inputs/homebrew/imazing.json (or explicitly confirm and document if you intend to keep the "Developer tools" override).ee/maintained-apps/outputs/imazing/darwin.json (1)
19-20: Uninstall script uses version-specific bundle ID inconsistent with detection and install scripts.The uninstall script (ref
0afea46a) callsquit_application 'com.DigiDNA.iMazing3.5.2.24017Mac', while the detection queries and install script both use the genericcom.DigiDNA.iMazing3Mac. If a user has a different iMazing version installed, the uninstall script will fail to quit the application since the running app likely reports the generic bundle ID.Use
com.DigiDNA.iMazing3Macin the uninstall script to match the detection and install logic.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ee/maintained-apps/outputs/imazing/darwin.json` around lines 19 - 20, The uninstall script uses version-specific bundle IDs in calls to quit_application (e.g., 'com.DigiDNA.iMazing3.5.2.24017Mac' and its .Mini variant) which prevents quitting the app if a different version is installed; change those calls to the generic bundle ID used by detection/install ('com.DigiDNA.iMazing3Mac' and 'com.DigiDNA.iMazing3Mac.Mini') so quit_application matches quit_and_track_application and relaunch_application logic and will correctly detect and quit the running app.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ee/maintained-apps/outputs/imazing/darwin.json`:
- Around line 19-20: The uninstall script uses version-specific bundle IDs in
calls to quit_application (e.g., 'com.DigiDNA.iMazing3.5.2.24017Mac' and its
.Mini variant) which prevents quitting the app if a different version is
installed; change those calls to the generic bundle ID used by detection/install
('com.DigiDNA.iMazing3Mac' and 'com.DigiDNA.iMazing3Mac.Mini') so
quit_application matches quit_and_track_application and relaunch_application
logic and will correctly detect and quit the running app.
In `@it-and-security/fleets/workstations.yml`:
- Around line 317-320: The categories for the imazing entry (slug:
imazing/darwin) in workstations.yml are inconsistent with the maintained app
definition; update the categories array for the imazing/darwin entry to
["Utilities"] to match ee/maintained-apps/inputs/homebrew/imazing.json (or
explicitly confirm and document if you intend to keep the "Developer tools"
override).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f4bdf82f-4075-430c-ab27-7298057a8597
📒 Files selected for processing (9)
ee/maintained-apps/inputs/homebrew/imazing-profile-editor.jsonee/maintained-apps/inputs/homebrew/imazing.jsonee/maintained-apps/outputs/apps.jsonee/maintained-apps/outputs/imazing/darwin.jsonfrontend/pages/SoftwarePage/components/icons/index.tsit-and-security/fleets/workstations.ymlit-and-security/lib/all/labels/macs-with-fleet-maintained-apps-installed.ymlit-and-security/lib/macos/policies/patch-fleet-maintained-apps.ymlwebsite/config/routes.js
💤 Files with no reviewable changes (1)
- ee/maintained-apps/inputs/homebrew/imazing-profile-editor.json
Replace the fleet-maintained app record for "iMazing Profile Editor" with the full "iMazing" app. Deleted the old input file and added a new input for imazing; renamed output paths and updated app metadata (bundle identifier, slug, categories). Bumped version to 3.5.2 and updated installer URL, install/uninstall script refs and SHA256. Updated frontend icon mapping and website routes to point to the new imazing slug, and adjusted fleet configs: workstation software slug, dynamic label query, and macOS patch policy to reference imazing/darwin and the new bundle identifier.
Summary by CodeRabbit
New Features
Updates