Reset verified certificates to pending during Android host re-enrollment (#43443)#43602
Merged
getvictor merged 1 commit intorc-minor-fleet-v4.84.0from Apr 17, 2026
Merged
Conversation
…ent (#43443) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #42600 Unreleased bug: #42600 (comment) # Checklist for submitter ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [x] Confirmed that the fix is not expected to adversely impact load test results <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Re-enrolling devices now fully reset certificate templates: templates return to pending (install retained), retry counts and delivery metadata are cleared to avoid stale state. * **Behavior** * Re-enrollment explicitly deletes prior device certificate entries before creating fresh pending templates to prevent duplicates and stale data. * **Tests** * Added tests covering Android re-enrollment to verify templates are recreated and metadata is cleared. <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit 67d0c57)
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.84.0 #43602 +/- ##
=========================================================
Coverage ? 66.86%
=========================================================
Files ? 2579
Lines ? 207114
Branches ? 9239
=========================================================
Hits ? 138485
Misses ? 56023
Partials ? 12606
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
ksykulev
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #42600
Unreleased bug:
#42600 (comment)
Checklist for submitter
Testing
For unreleased bug fixes in a release candidate, one of:
Summary by CodeRabbit
Bug Fixes
Re-enrolling devices now fully reset certificate templates: templates return to pending (install retained), retry counts and delivery metadata are cleared to avoid stale state.
Behavior
Re-enrollment explicitly deletes prior device certificate entries before creating fresh pending templates to prevent duplicates and stale data.
Tests
Added tests covering Android re-enrollment to verify templates are recreated and metadata is cleared.
(cherry picked from commit 67d0c57)