Skip to content

Add AWS VPN Client for macOS to testing and QA#43948

Closed
harrisonravazzolo wants to merge 1 commit intomainfrom
harrisonravazzolo-patch-3
Closed

Add AWS VPN Client for macOS to testing and QA#43948
harrisonravazzolo wants to merge 1 commit intomainfrom
harrisonravazzolo-patch-3

Conversation

@harrisonravazzolo
Copy link
Copy Markdown
Member

@harrisonravazzolo harrisonravazzolo commented Apr 22, 2026

Added AWS VPN Client for macOS to fleet maintained apps.

Summary by CodeRabbit

  • New Features
    • AWS VPN Client for macOS is now available through self-service deployment for designated user groups.

Added AWS VPN Client for macOS to fleet maintained apps.
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

Walkthrough

The YAML configuration file was updated to add a reporting entry for the macOS app aws-vpn-client/darwin under reports.software.packages.fleet_maintained_apps. The new entry enables self-service mode, filters by a specific IdP group label (SAML-aws-vpn), and assigns the Utilities category. A comment marker was removed and replaced with whitespace. The change consists of 7 added lines and 1 removed line.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal but directly relevant to the change. However, it does not follow the repository's required PR description template with checklist items. Fill out the standard PR template with relevant checklist items, including indication of whether manual testing was performed and if this is a configuration-only change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding AWS VPN Client for macOS to testing and QA configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch harrisonravazzolo-patch-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
it-and-security/fleets/testing-and-qa.yml (1)

55-62: Move the macOS section marker above the new app entry.

The new aws-vpn-client/darwin entry looks valid, but it now sits before the # macOS apps marker. Align this with it-and-security/fleets/workstations.yml:257-267 so future additions stay grouped correctly.

♻️ Proposed comment placement cleanup
   fleet_maintained_apps:
+    # macOS apps
     - slug: aws-vpn-client/darwin # AWS VPN Client for macOS
       self_service: true
       labels_include_any:
         - "IdP group: SAML-aws-vpn"
       categories:
         - Utilities
-    # macOS apps
     # Windows apps
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@it-and-security/fleets/testing-and-qa.yml` around lines 55 - 62, The new
aws-vpn-client/darwin entry under fleet_maintained_apps was inserted above the
existing section marker; move the comment line "# macOS apps" so it appears
before the aws-vpn-client/darwin block (i.e., reorder the lines so the "# macOS
apps" marker precedes the slug entry), keeping the slug, self_service,
labels_include_any and categories fields unchanged to match the grouping used in
the workstations.yml example.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@it-and-security/fleets/testing-and-qa.yml`:
- Around line 55-62: The new aws-vpn-client/darwin entry under
fleet_maintained_apps was inserted above the existing section marker; move the
comment line "# macOS apps" so it appears before the aws-vpn-client/darwin block
(i.e., reorder the lines so the "# macOS apps" marker precedes the slug entry),
keeping the slug, self_service, labels_include_any and categories fields
unchanged to match the grouping used in the workstations.yml example.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 393fa378-1d1a-43eb-bcec-a6c634cce677

📥 Commits

Reviewing files that changed from the base of the PR and between 96620f1 and 2ba6772.

📒 Files selected for processing (1)
  • it-and-security/fleets/testing-and-qa.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants