Skip to content

Remove non-existant routes#44093

Merged
juan-fdz-hawa merged 2 commits intomainfrom
38044-fix-api-endpoint-list
Apr 23, 2026
Merged

Remove non-existant routes#44093
juan-fdz-hawa merged 2 commits intomainfrom
38044-fix-api-endpoint-list

Conversation

@juan-fdz-hawa
Copy link
Copy Markdown
Contributor

@juan-fdz-hawa juan-fdz-hawa commented Apr 23, 2026

Fixes invalid routes introduced in #44060

Summary by CodeRabbit

  • Breaking Changes
    • Removed endpoint for updating Recovery Lock enforcement (recovery lock password).
    • Removed endpoint for updating the setup experience script.
    • Replaced the singular configuration profile status route with a pluralized route for retrieving configuration profile status.

@juan-fdz-hawa juan-fdz-hawa requested a review from a team as a code owner April 23, 2026 22:24
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 03117dab-a588-48d6-8eba-ed3ca00cd436

📥 Commits

Reviewing files that changed from the base of the PR and between 652fb73 and 887c312.

📒 Files selected for processing (1)
  • server/api_endpoints/api_endpoints.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • server/api_endpoints/api_endpoints.yml

Walkthrough

This PR updates the API endpoint registry file by removing three endpoint declarations: POST /api/v1/fleet/recovery_lock_password, GET /api/v1/fleet/configuration_profile/:profile_uuid/status, and PUT /api/v1/fleet/setup_experience/script. It adds a replacement route GET /api/v1/fleet/configuration_profiles/:profile_uuid/status (pluralized). Net diff shows three lines added and nine lines removed; no other endpoints were introduced.

Possibly related PRs

  • PR 44060: Modifies the same server/api_endpoints/api_endpoints.yml and overlaps on changes to Recovery Lock, configuration profile status routes, and setup experience script endpoints.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required information from the template such as related issue link, checklist items, testing details, and database migration checks. Add a proper related issue link, complete the relevant checklist items, and document testing and validation performed for this route removal.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing non-existent routes from the API endpoint definitions, which aligns with the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 38044-fix-api-endpoint-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

MagnusHJensen
MagnusHJensen previously approved these changes Apr 23, 2026
display_name: "Get macOS settings statistics"
deprecated: true
- method: "GET"
path: "/api/v1/fleet/configuration_profile/:profile_uuid/status"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it /api/_version_/fleet/configuration_profiles/{profile_uuid}/status?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - let me fix that

Comment thread server/api_endpoints/api_endpoints.yml
Comment thread server/api_endpoints/api_endpoints.yml
Copy link
Copy Markdown
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some questions.

Comment thread server/api_endpoints/api_endpoints.yml
@juan-fdz-hawa juan-fdz-hawa merged commit 039bebd into main Apr 23, 2026
4 checks passed
@juan-fdz-hawa juan-fdz-hawa deleted the 38044-fix-api-endpoint-list branch April 23, 2026 22:45
rachaelshaw pushed a commit that referenced this pull request May 4, 2026
Removes some invalid routes that were discovered in
#44093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants