Skip to content

Enable 1Password in fleets and patch policies#44182

Merged
allenhouchins merged 1 commit intomainfrom
allenhouchins-re-enable-1password
Apr 25, 2026
Merged

Enable 1Password in fleets and patch policies#44182
allenhouchins merged 1 commit intomainfrom
allenhouchins-re-enable-1password

Conversation

@allenhouchins
Copy link
Copy Markdown
Member

@allenhouchins allenhouchins commented Apr 25, 2026

Uncomment 1Password entries in workstations.yml so 1Password is managed as a fleet_maintained_app for both macOS and Windows. Commented out the separate Windows 1Password installed policy path and enabled the corresponding patch checks in macos/windows/patch-fleet-maintained-apps.yml to surface/update out-of-date 1Password installations.

Summary by CodeRabbit

  • New Features

    • 1Password is now available as a self-service application for installation on macOS and Windows with guided setup experience.
  • Chores

    • Activated automatic patch update policies for 1Password on both platforms with calendar-driven event scheduling to keep installations current.

Uncomment 1Password entries in workstations.yml so 1Password is managed as a fleet_maintained_app for both macOS and Windows. Commented out the separate Windows 1Password installed policy path and enabled the corresponding patch checks in macos/windows/patch-fleet-maintained-apps.yml to surface/update out-of-date 1Password installations.
@allenhouchins allenhouchins marked this pull request as ready for review April 25, 2026 03:20
Copilot AI review requested due to automatic review settings April 25, 2026 03:20
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@allenhouchins allenhouchins merged commit 7fde291 into main Apr 25, 2026
4 of 5 checks passed
@allenhouchins allenhouchins deleted the allenhouchins-re-enable-1password branch April 25, 2026 03:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 403d76bd-609e-4450-b1d0-4593ffc20224

📥 Commits

Reviewing files that changed from the base of the PR and between caef460 and 4213b10.

📒 Files selected for processing (3)
  • it-and-security/fleets/workstations.yml
  • it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml
  • it-and-security/lib/windows/policies/patch-fleet-maintained-apps.yml

Walkthrough

  • it-and-security/fleets/workstations.yml: Comments out the Windows 1Password “installed” policy path and enables Fleet-maintained app entries for 1Password on macOS (1password/darwin) and Windows (1password/windows), both with self_service: true, setup_experience: true, and category: Security.
  • it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml: Activates the 1Password patch policy for fleet_maintained_app_slug: 1password/darwin with labels_include_any (“Macs with 1Password installed”), install_software: false, and calendar_events_enabled: true.
  • it-and-security/lib/windows/policies/patch-fleet-maintained-apps.yml: Activates the Windows 1Password patch policy targeting x86 hosts with 1Password installed and enables calendar_events_enabled: true.

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-re-enable-1password

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants