Skip to content

Enable Nudge auto-install and comment policy#44185

Merged
allenhouchins merged 1 commit intomainfrom
allenhouchins-fix-nudge-policies
Apr 25, 2026
Merged

Enable Nudge auto-install and comment policy#44185
allenhouchins merged 1 commit intomainfrom
allenhouchins-fix-nudge-policies

Conversation

@allenhouchins
Copy link
Copy Markdown
Member

@allenhouchins allenhouchins commented Apr 25, 2026

Comment out the nudge-installed policy in it-and-security/fleets/workstations.yml and set install_software: true for the Nudge fleet-maintained app in it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml. This ensures Fleet will automatically install/patch Nudge on matching Macs (using the existing install-nudge-assets policy) rather than relying on the nudge-installed enforcement entry.

Summary by CodeRabbit

  • Bug Fixes
    • Disabled a macOS policy for workstations, removing it from policy evaluation.
    • Enabled software installation in the macOS update policy, allowing updates to proceed instead of being blocked.

Comment out the nudge-installed policy in it-and-security/fleets/workstations.yml and set install_software: true for the Nudge fleet-maintained app in it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml. This ensures Fleet will automatically install/patch Nudge on matching Macs (using the existing install-nudge-assets policy) rather than relying on the nudge-installed enforcement entry.
@allenhouchins allenhouchins marked this pull request as ready for review April 25, 2026 03:39
Copilot AI review requested due to automatic review settings April 25, 2026 03:39
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@allenhouchins allenhouchins merged commit 466ab44 into main Apr 25, 2026
4 of 5 checks passed
@allenhouchins allenhouchins deleted the allenhouchins-fix-nudge-policies branch April 25, 2026 03:39
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 46c507b2-e6b2-43ee-bdcb-deb05e367c97

📥 Commits

Reviewing files that changed from the base of the PR and between 7fde291 and e01104e.

📒 Files selected for processing (2)
  • it-and-security/fleets/workstations.yml
  • it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml

Walkthrough

The changes disable the nudge macOS policy by commenting out the nudge-installed.yml entry in the workstations policy configuration file. Simultaneously, the install_software setting is toggled from false to true in the patch-fleet-maintained-apps policy configuration, enabling software installation for that policy. The modifications affect fleet workstation policy management without altering policy ordering or other policy entries.

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-fix-nudge-policies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants