Update Fleet-maintained apps#44622
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughThis pull request updates two maintained-app version entries in the Fleet inventory. The Dialpad Darwin entry is updated from version 2603.3.5 to 2604.0.0, with the corresponding SQL version comparison threshold adjusted to match. The Granola Windows entry is updated from version 7.162.2 to 7.162.5, including changes to the installer URL, SHA256 checksum, and SQL version comparison threshold to align with the new version. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ee/maintained-apps/outputs/granola/windows.json`:
- Line 7: The patched SQL in queries.patched currently only filters by
version_compare(version, '7.162.5') < 0 and can mis-evaluate when
programs.version is NULL or empty; update the inner NOT EXISTS subquery (the
clause building the condition for programs rows) to also require version IS NOT
NULL (and optionally version <> '') before calling version_compare so NULL/empty
values don't make the comparison return NULL and incorrectly mark the app as
patched; locate the patched string in the JSON (queries.patched) and add the
extra predicates alongside the existing version_compare check.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2baa7fdf-bc7c-49a9-ac4f-4a2af1fb94ae
📒 Files selected for processing (2)
ee/maintained-apps/outputs/dialpad/darwin.jsonee/maintained-apps/outputs/granola/windows.json
| "queries": { | ||
| "exists": "SELECT 1 FROM programs WHERE name LIKE 'Granola %' AND publisher = 'Granola';", | ||
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name LIKE 'Granola %' AND publisher = 'Granola' AND version_compare(version, '7.162.2') < 0);" | ||
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name LIKE 'Granola %' AND publisher = 'Granola' AND version_compare(version, '7.162.5') < 0);" |
There was a problem hiding this comment.
Guard queries.patched against NULL/empty programs.version.
Right now, the patched query only checks version_compare(version, '7.162.5') < 0. If programs.version can ever be NULL (or empty), that condition may evaluate to NULL/false, which makes the inner NOT EXISTS (...) succeed and could incorrectly mark the app as “already patched”.
Consider adding version IS NOT NULL (and optionally version <> '') inside the inner EXISTS subquery.
🛠️ Proposed patch to the `patched` query string
- "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name LIKE 'Granola %' AND publisher = 'Granola' AND version_compare(version, '7.162.5') < 0);"
+ "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name LIKE 'Granola %' AND publisher = 'Granola' AND version IS NOT NULL AND version_compare(version, '7.162.5') < 0);"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name LIKE 'Granola %' AND publisher = 'Granola' AND version_compare(version, '7.162.5') < 0);" | |
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name LIKE 'Granola %' AND publisher = 'Granola' AND version IS NOT NULL AND version_compare(version, '7.162.5') < 0);" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ee/maintained-apps/outputs/granola/windows.json` at line 7, The patched SQL
in queries.patched currently only filters by version_compare(version, '7.162.5')
< 0 and can mis-evaluate when programs.version is NULL or empty; update the
inner NOT EXISTS subquery (the clause building the condition for programs rows)
to also require version IS NOT NULL (and optionally version <> '') before
calling version_compare so NULL/empty values don't make the comparison return
NULL and incorrectly mark the app as patched; locate the patched string in the
JSON (queries.patched) and add the extra predicates alongside the existing
version_compare check.
|
Closing in favor of #44635. |
2 participants
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit
Chores