Skip to content

home-page-button-fix#45004

Merged
mike-j-thomas merged 1 commit into
mainfrom
homepage-button-fix
May 8, 2026
Merged

home-page-button-fix#45004
mike-j-thomas merged 1 commit into
mainfrom
homepage-button-fix

Conversation

@mike-j-thomas
Copy link
Copy Markdown
Member

@mike-j-thomas mike-j-thomas commented May 8, 2026

Summary by CodeRabbit

  • Chores
    • Removed call-to-action links from feature sections on the homepage.

New buttons break responsive website layout. Commented out until Eric can fix properly.
@fleet-release fleet-release added the ~ga4-annotation This label is automatically applied to certain website changes label May 8, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack

Walkthrough

This PR removes three call-to-action links from the homepage template by commenting out their anchor elements instead of rendering them. Specifically, CTAs linking to /device-management, /orchestration, and /infrastructure-as-code features are replaced with HTML comments across the "All features, flexible deployment", "Tell your story", and "Apply across your fleet" feature sections respectively. No other template logic or component behavior is changed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal but contains key information: it references the related PR (#45001) and explains the temporary nature of the fix. However, it does not follow the provided template structure with sections, checklists, or required validations. Add appropriate template sections and checkboxes. At minimum, confirm the related issue (#45001), indicate whether testing was performed, and note if a changes file was added.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'home-page-button-fix' refers to the main change (commenting out problematic buttons on homepage), but lacks specificity about what the fix entails or why it was needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch homepage-button-fix

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (3)
website/views/pages/homepage.ejs (3)

149-149: ⚡ Quick win

Temporary fix acknowledged; consider adding a tracking comment.

The third commented-out CTA maintains consistency with the previous two. Adding a TODO comment completes the tracking pattern.

📝 Suggested tracking comment
-          <!-- <a purpose="cta-button" href="/infrastructure-as-code">Manage devices as code</a> -->
+          <!-- TODO: Restore this CTA once responsive layout fix is implemented (see PR `#45001`) -->
+          <!-- <a purpose="cta-button" href="/infrastructure-as-code">Manage devices as code</a> -->
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@website/views/pages/homepage.ejs` at line 149, Add a short tracking/TODO
comment above the commented-out CTA anchor so the temporary removal is clearly
tracked like the other two CTAs; locate the commented line containing the anchor
with href="/infrastructure-as-code" and prepend a one-line TODO/comment noting
why it’s disabled and an owner or ticket reference.

95-95: ⚡ Quick win

Temporary fix acknowledged; consider adding a tracking comment.

The commented-out CTA is correct for this temporary workaround. However, adding a TODO comment would help track that this needs to be restored once the responsive layout issue is properly fixed.

📝 Suggested tracking comment
-          <!-- <a purpose="cta-button" href="/device-management">Explore device management</a> -->
+          <!-- TODO: Restore this CTA once responsive layout fix is implemented (see PR `#45001`) -->
+          <!-- <a purpose="cta-button" href="/device-management">Explore device management</a> -->
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@website/views/pages/homepage.ejs` at line 95, Add a short TODO tracking
comment near the commented-out CTA anchor to mark this as a temporary workaround
and remind engineers to restore it when the responsive layout is fixed; locate
the commented line containing the anchor "<a purpose=\"cta-button\"
href=\"/device-management\">Explore device management</a>" in homepage.ejs and
insert a concise TODO with context and an issue or ticket reference if
available.

119-119: ⚡ Quick win

Temporary fix acknowledged; consider adding a tracking comment.

The commented-out CTA follows the same pattern as the previous one. Adding a TODO comment here as well would help maintain consistency and tracking.

📝 Suggested tracking comment
-          <!-- <a purpose="cta-button" href="/orchestration">More about visibility</a> -->
+          <!-- TODO: Restore this CTA once responsive layout fix is implemented (see PR `#45001`) -->
+          <!-- <a purpose="cta-button" href="/orchestration">More about visibility</a> -->
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@website/views/pages/homepage.ejs` at line 119, Add a short TODO tracking
comment immediately above the commented-out CTA anchor (<a purpose="cta-button"
href="/orchestration">More about visibility</a>) indicating this is a temporary
removal and referencing the issue/ticket or owner (e.g., "TODO: restore CTA
after X; see ISSUE-123 / `@owner`"), so the commented-out line is traceable and
consistent with the previous CTA comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@website/views/pages/homepage.ejs`:
- Line 149: Add a short tracking/TODO comment above the commented-out CTA anchor
so the temporary removal is clearly tracked like the other two CTAs; locate the
commented line containing the anchor with href="/infrastructure-as-code" and
prepend a one-line TODO/comment noting why it’s disabled and an owner or ticket
reference.
- Line 95: Add a short TODO tracking comment near the commented-out CTA anchor
to mark this as a temporary workaround and remind engineers to restore it when
the responsive layout is fixed; locate the commented line containing the anchor
"<a purpose=\"cta-button\" href=\"/device-management\">Explore device
management</a>" in homepage.ejs and insert a concise TODO with context and an
issue or ticket reference if available.
- Line 119: Add a short TODO tracking comment immediately above the
commented-out CTA anchor (<a purpose="cta-button" href="/orchestration">More
about visibility</a>) indicating this is a temporary removal and referencing the
issue/ticket or owner (e.g., "TODO: restore CTA after X; see ISSUE-123 /
`@owner`"), so the commented-out line is traceable and consistent with the
previous CTA comment.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: df23e23e-37a7-4f1c-86e3-86e6a019cecb

📥 Commits

Reviewing files that changed from the base of the PR and between f3f830b and de79947.

📒 Files selected for processing (1)
  • website/views/pages/homepage.ejs

@mike-j-thomas mike-j-thomas merged commit b98b063 into main May 8, 2026
9 checks passed
@mike-j-thomas mike-j-thomas deleted the homepage-button-fix branch May 8, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~ga4-annotation This label is automatically applied to certain website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants