Update Fleet-maintained apps#45251
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Script Diff Resultsee/maintained-apps/outputs/firefox/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/grammarly-desktop/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/granola/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/teleport-connect/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/teleport-suite/darwin.json=== Install // 3ac40527 -> 70c991f9 ===
--- /tmp/old.ZxuqVi 2026-05-12 16:45:09.514100020 +0000
+++ /tmp/new.kxoP7o 2026-05-12 16:45:09.515100014 +0000
@@ -96,5 +96,5 @@
# install pkg files
quit_and_track_application 'com.gravitational.teleport.tsh'
-sudo installer -pkg "$TMPDIR/teleport-18.7.6.pkg" -target /
+sudo installer -pkg "$TMPDIR/teleport-18.8.0.pkg" -target /
relaunch_application 'com.gravitational.teleport.tsh'
=== Uninstall Script (no changes) === |
WalkthroughThis PR updates macOS maintained-apps metadata for five applications. Firefox, Grammarly Desktop, Granola, and Teleport Connect receive standard version bumps with updated version numbers, installer URLs, and SHA256 checksums. The patched query version comparison threshold is updated in each. Teleport Suite receives the same updates plus a change to the install script reference (from Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
ee/maintained-apps/outputs/teleport-suite/darwin.json (2)
20-20: ⚖️ Poor tradeoffInstall script contains hard-coded version in package filename.
The install script references
teleport-18.8.0.pkgwith a hard-coded version. This creates maintenance overhead, requiring a new script reference for every version update.Consider refactoring to derive the package filename from the installer path or version field, for example:
# Extract version from INSTALLER_PATH or use a variable PKG_FILE=$(basename "$INSTALLER_PATH") sudo installer -pkg "$TMPDIR/$PKG_FILE" -target /This would eliminate the need to update the install script for version-only changes.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/outputs/teleport-suite/darwin.json` at line 20, The install script hard-codes the package name in the installer invocation; update the installer call to derive the pkg filename from INSTALLER_PATH (or a PKG_FILE variable) so version changes don't require editing the script: use the existing TMPDIR and INSTALLER_PATH variables to compute the package basename (e.g., PKG_FILE=$(basename "$INSTALLER_PATH")) and replace the literal "teleport-18.8.0.pkg" in the sudo installer line with the derived "$TMPDIR/$PKG_FILE"; this change touches the installer invocation that sits after quit_and_track_application and before relaunch_application.
4-12: ⚡ Quick winInstall script contains hard-coded version number; consider refactoring to avoid script updates on every version bump.
The script ref changed from
3ac40527to70c991f9because the install script hard-codes the package filename asteleport-18.8.0.pkg. This pattern requires creating a new script for every version update. The script could be refactored to dynamically determine the package filename (e.g., usingfind "$TMPDIR" -name "teleport-*.pkg"or extracting it from$INSTALLER_PATH) to decouple version updates from script changes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/outputs/teleport-suite/darwin.json` around lines 4 - 12, The install script referenced by install_script_ref was changed because it hard-codes the package filename "teleport-18.8.0.pkg"; update that install script (the file behind install_script_ref) to stop embedding the version: locate the package dynamically (e.g., use find "$TMPDIR" -name "teleport-*.pkg" or derive the filename from $INSTALLER_PATH/$INSTALLER_URL) and update the installer invocation to use the discovered path, so future version bumps only change the version field (version/installer_url/sha256) and not the install_script_ref.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ee/maintained-apps/outputs/teleport-suite/darwin.json`:
- Line 20: The install script hard-codes the package name in the installer
invocation; update the installer call to derive the pkg filename from
INSTALLER_PATH (or a PKG_FILE variable) so version changes don't require editing
the script: use the existing TMPDIR and INSTALLER_PATH variables to compute the
package basename (e.g., PKG_FILE=$(basename "$INSTALLER_PATH")) and replace the
literal "teleport-18.8.0.pkg" in the sudo installer line with the derived
"$TMPDIR/$PKG_FILE"; this change touches the installer invocation that sits
after quit_and_track_application and before relaunch_application.
- Around line 4-12: The install script referenced by install_script_ref was
changed because it hard-codes the package filename "teleport-18.8.0.pkg"; update
that install script (the file behind install_script_ref) to stop embedding the
version: locate the package dynamically (e.g., use find "$TMPDIR" -name
"teleport-*.pkg" or derive the filename from $INSTALLER_PATH/$INSTALLER_URL) and
update the installer invocation to use the discovered path, so future version
bumps only change the version field (version/installer_url/sha256) and not the
install_script_ref.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b543f25f-b4d9-4173-b554-0607a3625c2a
📒 Files selected for processing (5)
ee/maintained-apps/outputs/firefox/darwin.jsonee/maintained-apps/outputs/grammarly-desktop/darwin.jsonee/maintained-apps/outputs/granola/darwin.jsonee/maintained-apps/outputs/teleport-connect/darwin.jsonee/maintained-apps/outputs/teleport-suite/darwin.json
|
Closing in favor of #45288. |
2 participants
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit